This can become handy when we separate core code and formulae. For
example, we could use `cd $(brew --repo homebrew/core)` to go to core
tap path.

Closes Homebrew/homebrew#50346.

Signed-off-by: Xu Cheng <xucheng@me.com>

As discovered in Homebrew/homebrew#50256, this becomes a performance bottleneck as we are
repeating construct same Pathname object.

At the same, this commit makes the behaviors between Tap and CoreTap more
consistence.

Closes Homebrew/homebrew#50282.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Since we support `apply` DSL in the `patch` block, external
patch files could be any compressed archive. As result, it
could introduce dependencies like xz, 7z etc.

Add the resource of ExternalPatch to dependency_collector, so
we could track these resource dependencies.

Closes Homebrew/homebrew#50318.

Signed-off-by: Xu Cheng <xucheng@me.com>

This is the only place we advise `:admin` as well so might as well
change this one.

Closes Homebrew/homebrew#50279.

Closes Homebrew/homebrew#50295.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

The idea is to let `scm/git` to handle all of git location resolution
throughout Homebrew codebase.

Closes Homebrew/homebrew#50116.

Signed-off-by: Xu Cheng <xucheng@me.com>

* Use `ENV/scm/git` to check whether git is installed.
* Use `brew install git` to enforce pre-install checks such as sudo
  check.

`/usr/bin/<tool>` will be a popup stub under such configuration.

The idea is to let `scm/git` to handle all of git location resolution
throughout Homebrew codebase.

`Library/ENV` like `Library/Homebrew` is part of Homebrew basecode. It
should be able to be accessed during the `brew tests`.

By adding HOMEBREW_ENV_PATH variable, we allow test suit to locate these
codes.

Closes Homebrew/homebrew#50272.

Signed-off-by: Xu Cheng <xucheng@me.com>

This reverts commit 0b38f9b286bc61e2b2d2232f80ea8ebc5909fb07.

Fixes Homebrew/homebrew#50050. Closes Homebrew/homebrew#50059.

Fixes https://github.com/Homebrew/homebrew/issues/50131



This commit removes the error backtrace and improves the error message
if a bad regexp is passed to `brew search`.

Closes Homebrew/homebrew#50173.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>

This reverts commit 8c7f3d859e8f715b6c63e4fe75e7a636aee4167f.

Closes Homebrew/homebrew#50154.

cf. Homebrew/homebrew#50154

Resolves an issue where xcode-select output with a terminal slash leads
to superenv failing to strip system library paths from ccld-style
invocations.

Fixes Homebrew/homebrew#49731. Discussion in Homebrew/homebrew#50154.

Closes Homebrew/homebrew#50146.

Signed-off-by: Alex Dunn <adunn@ucsb.edu>

See https://github.com/Homebrew/homebrew/pull/50130#discussion_r56254860

Upstream has ignored the 64-bit patches from the original Homebrew pull
request, as well as subsequent 64-bit reports:
https://sourceforge.net/p/libodbcxx/bugs/25/



Trunk hasn't been updated since 2010 and the last tag was in 2009.

Closes Homebrew/homebrew#49980.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

This reverts commit 7032591bd44a8f50aaa55574ac97cd5cb7261460 and
commit 946c6deb4b5168ad2ec15e62aa6e81181e9e246c.

Ref:
 - http://www.w3.org/TR/xml/#charsets
 - http://stackoverflow.com/a/14323524



Closes Homebrew/homebrew#50092.

Signed-off-by: Xu Cheng <xucheng@me.com>

Closes Homebrew/homebrew#50067.

Signed-off-by: Andrew Janke <andrew@apjanke.net>

Running brew audit --strict --online on a formula with a GitHub
homepage/url would crash if HOMEBREW_NO_GITHUB_API is set because
GitHub.repository returns `nil` and the audit code assumes it always
returns a hash.

Closes Homebrew/homebrew#50054.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

HOMEBREW_MAKE_JOBS can be a multidigit number. The regex should match
the entire number not just the last digit.

Closes Homebrew/homebrew#50016.

Signed-off-by: Tim D. Smith <git@tim-smith.us>

Fixes Homebrew/homebrew#49757
Closes Homebrew/homebrew#49775

Closes Homebrew/homebrew#49947.

Signed-off-by: Andrew Janke <andrew@apjanke.net>

The upstream URL/Homepage have been 404 for a while now and there's no credible
alternative homepage/download. We're using the wayback machine but essentially
if this breaks we're left as the sole supporter of the project and we don't
want to be in that position as a package manager.

Closes Homebrew/homebrew#47168.

Closes Homebrew/homebrew#50021.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Mozilla have dropped support for xulrunner and currently no developer has picked it up.

On our side of the deal, beyond this summer when a new major release of OS X is
released we'll lose the ability to build & test this formula completely as it
currently doesn't build on anything newer than Mavericks.

Ref: https://lists.mozilla.org/pipermail/dev-platform/2015-July/011178.html
Ref: https://bugzilla.mozilla.org/show_bug.cgi?id=1221724

Closes Homebrew/homebrew#33558.

Upstream have dropped support for OS X in the latest release.

Closes Homebrew/homebrew#49442.

Upstream is completely dead, formula hasn't been updated to the most recent
release which was available years ago, tried to update and resulting install
doesn't seem to function as expected.

Closes Homebrew/homebrew#49635.

Looks like the bintray publish_wait_for_secs was being ignored because the
content type wasn't being set, so it defaulted to x-www-form-urlencoded
instead of application/json.

Changes the  timeout to 0 to preserve current non-blocking behavior, which
we want in case multiple formulae are being updated.

Closes Homebrew/homebrew#49951.

Signed-off-by: Andrew Janke <andrew@apjanke.net>

This needs to be `Homebrew $HOMEBREW_VERSION` so we can be adequately
filtered.

Closes Homebrew/homebrew#49961.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

- Use empty array when `git credential-osxkeychain` lookup fails to
  cache and avoid rerunning it when there's no valid results.
- Redirect `stderr` to avoid printing errors when there's a failure
  or no `git credential-osxkeychain` installed.

Closes Homebrew/homebrew#49954.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>