Some tests, that construct a Git repository for testing, will silently
fail if the global Git user isn't properly set up. There are valid use
cases for this, thus use a fixed commit author/committer for all tests
instead of relying on the user's configuration.

This tests all possible combinations of alpha, beta, RC, regular, and
patch versions. Also improves code coverage and partitions the version
comparison tests into more uniform chunks.

Closes Homebrew/homebrew#47669.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>

This only affects the behavior of `brew update` while being on a branch
`feature` that doesn't track the upstream branch. For simplicity, the
upstream branch is assumed to be called `master` (`@upstream_branch` in
the code). Consider the following simplified commit history:

        master      origin/master (current state of remote)
        |           |
A---B---C---D---E---F
     \
      G---H---I
              |
              feature (HEAD)

If `origin/master` is equal to `master` and also points at commit `C`,
then `brew update` will update both `master` and `origin/master` to `F`
and report on the changes in the range `C..F`.

However, if `origin/master` is equal to `E` because some commits have
been already fetched with `git fetch origin`, then `brew update` will
recreate `master` from `origin/master` and then pull in the commits from
the remote to update both to `F`. Because `master` gets recreated from
a younger `origin/master`, the report will only contain changes from the
range `E..F` (thus omitting the changes from `C..E`).

This commit adjusts the logic to not recreate `master` if it can be
safely fast-forwarded to `origin/master` (the common case). This fixes
the problem from the second scenario and again reports on the desired
range `C..F`.

Closes Homebrew/homebrew#46951.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>

Fixes: Homebrew/homebrew#47673.
Closes Homebrew/homebrew#47672.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>

If the test fails above `formula_file`’s definition this line fails
because `formula_file` is `nil`.

Closes Homebrew/homebrew#47663.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

Closes Homebrew/homebrew#47638.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#47484.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

Closes Homebrew/homebrew#47555.
Closes Homebrew/homebrew#47649.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

Closes Homebrew/homebrew#47646.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Stops Rubocop moaning about one line conditionals.

Closes Homebrew/homebrew#47537.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Fixes:
language/haskell.rb:65: warning: `*' interpreted as argument prefix

These self references are unnecessary.

Fixes this `brew readall` warning:

test_integration_cmds.rb:116: warning: ambiguous first argument; put parentheses or even spaces

Closes Homebrew/homebrew#47605.

Signed-off-by: Xu Cheng <xucheng@me.com>

Similar to which, except it returns all of paths where binary is found.
i.e. it's equivalent to `which -a`.

* Also with test case.

Closes Homebrew/homebrew#47584.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

This test wasn't running by default, so we missed that it wasn't
actually being executed - or that it was failing when running in the
testing environment.

As far as I can tell this is not, and has not, been used either in core
or in any tap, third party or otherwise, so just remove the feature and
its test.

Refs Homebrew/homebrew-games#383.

Happy new year 🎉 🎆

Fixes Homebrew/homebrew#47533.

Closes https://github.com/Homebrew/homebrew/issues/47532
Closes https://github.com/Homebrew/homebrew-dupes/issues/542

`echo` is missing since f3f6552c.

* Avoid parallel assignment.
* Avoid string manipulation.

* Avoid parallel assignment.
* Use Pathname#size instead of File#size
* Use Pathname#directory? instead of File#directory?
* Use basename to check `.DS_Store`. Original regex has poor
  performance, and may match with incorrect file.