Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/Homebrew/brew.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
  1. Apr 18, 2016
  2. Apr 17, 2016
  3. Apr 16, 2016
  4. Apr 14, 2016
  5. Apr 13, 2016
  6. Apr 12, 2016
  7. Apr 11, 2016
  8. Apr 10, 2016
  9. Apr 09, 2016
  10. Apr 08, 2016
    • Martin Afanasjew's avatar
      diagnostic: prefer guard clauses for readability · 1d9977b7
      Martin Afanasjew authored
      
      Guard clauses instead of if/unless blocks make the checks easier to
      understand and reduce nesting, thus improving overall readability.
      
      This includes the following additional minor changes:
      
      - Make indentation of commands consistent inside diagnostic messages.
      - Fix minor typos and inconsistent punctuation in diagnostic messages.
      - Fix here documents to always start with `<<-EOS.undent` on a new line,
        followed by the message (indented once), followed by `EOS` (at the
        same level like `<<-EOS.undent`).
      - Always separate the check logic (and guard clauses) from the following
        message by a single empty line (for consistency and readability).
      - Standardize on `message` as the variable name when diagnostic messages
        need to be constructed from multiple parts.
      - Where easily possible, adapt check logic to stay within 80-column
        limit, use more expressive variable names, and break down long
        expressions into multiple statements with intermediate results.
      
      Closes #49.
      
      Signed-off-by: default avatarMartin Afanasjew <martin@afanasjew.de>
      1d9977b7
    • Martin Afanasjew's avatar
      brew.sh: make sure to always use system 'awk' · 6a82bc49
      Martin Afanasjew authored
      This should prevent issues like #47 and make us more resilient.
      6a82bc49
    • Martin Afanasjew's avatar
      scm/git: prevent exec bomb with 'env :userpaths' · d7aa0c03
      Martin Afanasjew authored
      
      Using `git` from `Formula#install` can cause an exec bomb if used in a
      formula with `env :userpaths` because that causes both `Library/ENV/4.3`
      and `Library/ENV/scm` to be in PATH, both of which contain a `git`
      binary that is the same SCM wrapper. Those will mutually exec each other
      indefinitely as they fail to detect that they are the same wrapper.
      
      Extend the exec-bomb protection to check the paths after all symbolic
      links have been expanded to prevent this situation.
      
      Fixes #43.
      Fixes Homebrew/homebrew-core#133.
      Fixed Homebrew/homebrew-core#143.
      
      Closes #46.
      
      Signed-off-by: default avatarMartin Afanasjew <martin@afanasjew.de>
      d7aa0c03
  11. Apr 07, 2016
Loading