For consistency with other commands where there is a list of mutually
exclusive options of which exactly one has to be specified.

The options `--all`, `--installed`, and a list of formulae are mutually
exclusive arguments, of which exactly one is required.

Putting the Ruby 1.8 we use to run tests on 10.9 into the PATH adversely
affects formulae with a Ruby dependency (possibly other formulae, too).
Remove this hack, as it is no longer needed.

Closes Homebrew/homebrew#47694.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>

Particularly the `bundler` Gem requires the right Ruby binary to be in
the PATH to work correctly if the Ruby binary used to run Homebrew is
overridden via `HOMEBREW_RUBY_PATH` and thus intentionally not prefixed
to the PATH (as that would affect formulae with a Ruby dependency).

The workaround here is to prefix this path only when a Gem is activated
via `Homebrew.install_gem_setup_path!` (currently used in `brew man`,
`brew style`, and `brew tests`).

Closes Homebrew/homebrew#47675.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

This new `.gitignore` format produces consistent/expected `git status`
output with Git <2.7.0, Git >2.7.0 and libgit2 0.23.4.

Closes Homebrew/homebrew#47721.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

This reverts commit 5896555e5352b5e4f16f583ea444942cd1fc56bd.

It caused header-location issue on dual-developer-tool systems for certain
formulae. Will need looking at again, but we'll probably have to try and
do this a different way.

Closes Homebrew/homebrew#47668.

The output is too noisy and Travis gets upset.

Closes Homebrew/homebrew#47715.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

Closes Homebrew/homebrew#47710.

Closes Homebrew/homebrew#47665.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

Fixes Homebrew/homebrew#47684.

Closes Homebrew/homebrew#47540.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Tests shouldn't fail in case of an unavailable network or a deliberately
disabled access to the GitHub API.

Closes Homebrew/homebrew#47670.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>

Some tests, that construct a Git repository for testing, will silently
fail if the global Git user isn't properly set up. There are valid use
cases for this, thus use a fixed commit author/committer for all tests
instead of relying on the user's configuration.

This tests all possible combinations of alpha, beta, RC, regular, and
patch versions. Also improves code coverage and partitions the version
comparison tests into more uniform chunks.

Closes Homebrew/homebrew#47669.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>

This only affects the behavior of `brew update` while being on a branch
`feature` that doesn't track the upstream branch. For simplicity, the
upstream branch is assumed to be called `master` (`@upstream_branch` in
the code). Consider the following simplified commit history:

        master      origin/master (current state of remote)
        |           |
A---B---C---D---E---F
     \
      G---H---I
              |
              feature (HEAD)

If `origin/master` is equal to `master` and also points at commit `C`,
then `brew update` will update both `master` and `origin/master` to `F`
and report on the changes in the range `C..F`.

However, if `origin/master` is equal to `E` because some commits have
been already fetched with `git fetch origin`, then `brew update` will
recreate `master` from `origin/master` and then pull in the commits from
the remote to update both to `F`. Because `master` gets recreated from
a younger `origin/master`, the report will only contain changes from the
range `E..F` (thus omitting the changes from `C..E`).

This commit adjusts the logic to not recreate `master` if it can be
safely fast-forwarded to `origin/master` (the common case). This fixes
the problem from the second scenario and again reports on the desired
range `C..F`.

Closes Homebrew/homebrew#46951.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>

Fixes: Homebrew/homebrew#47673.
Closes Homebrew/homebrew#47672.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>

If the test fails above `formula_file`’s definition this line fails
because `formula_file` is `nil`.

Closes Homebrew/homebrew#47663.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

Closes Homebrew/homebrew#47638.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#47484.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

Closes Homebrew/homebrew#47555.
Closes Homebrew/homebrew#47649.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

Closes Homebrew/homebrew#47646.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Stops Rubocop moaning about one line conditionals.

Closes Homebrew/homebrew#47537.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Fixes:
language/haskell.rb:65: warning: `*' interpreted as argument prefix

These self references are unnecessary.

Fixes this `brew readall` warning:

test_integration_cmds.rb:116: warning: ambiguous first argument; put parentheses or even spaces

Closes Homebrew/homebrew#47605.

Signed-off-by: Xu Cheng <xucheng@me.com>

Similar to which, except it returns all of paths where binary is found.
i.e. it's equivalent to `which -a`.