Closes Homebrew/homebrew#9982

Fixes Homebrew/homebrew#13638.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

I managed to remove a return while fixing this yesterday. The whitespace changes made the diff unreadable so I missed this regression.

Why does this sort of thing still happen?

This stuff sucks. I'd like to just replace the dash with a directory division or tilde character. But this makes the code even more complicated, unless we can figure out how to migrate the taps.

Closes Homebrew/homebrew#12247.
Closes Homebrew/homebrew#12244.

Signed-off-by: Max Howell <mxcl@me.com>

Closes Homebrew/homebrew#13335.

Closes Homebrew/homebrew#13689.

Signed-off-by: Max Howell <mxcl@me.com>

There are subtle distinctions between writable? and writable_real? we don't
understand precisely why we need this, but it fixes the bugs :/

How did this get removed? Had a bug today where user had this but no doctor check so I was confused!

If the user owns the parent directory we have the rights to rmtree. At least I believe so.

Fixes Homebrew/homebrew#13714.

Closes Homebrew/homebrew#13431.

Signed-off-by: Max Howell <mxcl@me.com>

Fixes Homebrew/homebrew#12944.

Currently, if brew doctor detects untracked changes in the local repo,
it suggests doing 'git reset --hard', but that doesn't remove untracked
files. This change adds an additional suggestion to run 'git clean -f'
to remove them.

Closes Homebrew/homebrew#12814.

Signed-off-by: Max Howell <mxcl@me.com>

Changed the path to Library as we don't want to clean -f all over the whole /usr/local :P

Works rather damn well.

I considered `brew -i`, but we aren't a shell.

If a formula is in Formula due to tapping or otherwise, don't prohibit installation.

Really we should make the blacklist *really* stuff that should be blacklisted and then if it is available still require a --force. But currently with okay stuff like vim in there, and libxml2 being both blacklisted *and* in mxcl/master, we are screwing ourselves.

TL;DR we should do some work on this component.

Fixes Homebrew/homebrew#13234.

The short-circuit returns would cause the caching ||= syntax to be skipped. For me on my CLT-less install, this was noticeably slowing down brew for some operations due to the frequent calls to xcodebuild.

- patch no longer needed
- blacklist.rb: Removed version number because we forget to update it too often.

Closes Homebrew/homebrew#13997.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

Refs Homebrew/homebrew#13982.

We don't want bug reports about this crap, even though the user REALLY should listen to the warning message. What actually happens is they blame us instead.

This kind of warning in particular:

warning: Insecure world writable dir /usr/local/bin in PATH

You have to hold people's hands, they won't google anything.

Refs Homebrew/homebrew#13982.

Now that X11 components are specified as dependencies, users will be
prompted to install these components when necessary, and this check is
no longer needed.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Tell user exactly what command to use rather than thinking they'll figure it out by applying some negation logic to the main verb in the sentence they just read.

Closes Homebrew/homebrew#12790.

Fixes Homebrew/homebrew#12446.

About time right?

Removes dead symlinks in Formula and re-symlinks all Taps.

Closes Homebrew/homebrew#11565.

Repos can't at this point. Hard to easily fix so avoiding it until 2.0 or until someone moans enough.

Fix Homebrew/homebrew#11728, fix Homebrew/homebrew#12890, fix Homebrew/homebrew#13653, fix Homebrew/homebrew#13734, fix Homebrew/homebrew#13787, fix Homebrew/homebrew#13818,
fix Homebrew/homebrew#13939.

It's also necessary to delete LC_ALL or it overrides the new LANG.
LC_COLLATE is the problem variable but is affected by LANG and LC_ALL
so just use them instead. Extends the fix made to geoip in dc955c.

Fix Homebrew/homebrew#11728, fix Homebrew/homebrew#12890, fix Homebrew/homebrew#13653, fix Homebrew/homebrew#13734, fix Homebrew/homebrew#13787, fix Homebrew/homebrew#13818.

Possibly would help diagnose: Homebrew/homebrew#13853.