Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/Homebrew/brew.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
  1. Aug 31, 2018
  2. Aug 30, 2018
  3. Aug 29, 2018
    • commitay's avatar
      text_cop: update `cargo build` cop · 0ce58396
      commitay authored
      0ce58396
    • Dominyk Tiller's avatar
      cleanup_spec: test go_cache cleanup · b333f7ab
      Dominyk Tiller authored
      Unverified
      b333f7ab
    • Dominyk Tiller's avatar
      cleanup: cleanup go_cache · 318eb505
      Dominyk Tiller authored
      Unverified
      318eb505
    • Dominyk Tiller's avatar
      formula: always set GOCACHE · 4598995a
      Dominyk Tiller authored
      I hadn't planned to move on this so quickly but impressively core
      today had its first Go Module using PR, so this has become more useful
      than it would've been. Useful reading on the Modules system can be found
      via https://golang.org/doc/go1.11#modules.
      
      `GOCACHE` has been a thing for a while but it hasn't really been
      especially beneficial to us, so I've ignored it, but with the Go Modules
      system it can be incredibly useful in reducing build times & thus CI
      burden. A lot of this is explained rather nicely here:
        https://groups.google.com/forum/#!msg/golang-dev/RjSj4bGSmsw/KMHhU8fmAwAJ
      
      The upsides here for us are obvious:
      1) We do a *lot* of go-based builds, and the more things move over to the
      module system the more comprehensive that cache will become and we'll
      need to remotely fetch less dependencies, which massively speeds up
      build times even on high-speed connections.
      2) Module dependencies aren't limited per formula. If `hugo` fetches a
      dependency that is the same version as, for example, `wiki` also needs
      `wiki` won't bother to fetch that version remotely but instead will
      simply pluck it out of the cache.
      
      If we look at `hugo`, because it's the only formula so far with Module
      support:
      
      First build: `built in 1 minute 41 seconds`
      Second build: `built in 14 seconds`.
      
      It's worth noting perhaps that we can use just the module cache rather
      than the build cache + module cache combination, but doing so leads to
      a significant reduction in regained build time. A build under that
      system pops an average build time with `hugo` (after the first build)
      of ~70 seconds, which is only a 30 second saving on the first build.
      However, if we wanted to speed up builds whilst also not eating big chunks
      of disk space that is an option.
      
      The downside of a build cache + module cache system is disk usage.
      `go` does not exactly eat up disk space sparingly, and the cache size
      from `hugo` alone is 258.8MB. That could be an issue on CIs where disk
      space is already a squeeze at times, but it's not much different to how
      we let the `java_cache` behave now.
      
      All Module-supporting formulae need to do to use the shared cache is
      instead of deleting the `GOPATH` env we set everywhere replace it with
      this:
      ```
      ENV["GOPATH"] = "#{HOMEBREW_CACHE}/go_cache"
      ```
      Unverified
      4598995a
    • Michka Popoff's avatar
      superenv: Use 02 optimization flag for Linux builds · b7b5fb93
      Michka Popoff authored
      `-Os` produces sometimes bigger binaries on Linux.
      Also, llvm built with `-Os` is really slow at runtime for Linux.
      
      Using `-02` aligns us with what Debian does, and as we are compiling most of our stuff with gcc (and not clang), it makes sense to use `-02` on Linux.
      `-Os` does probably slightly different things when used on mac with llvm, compared to when it is used with gcc on Linux.
      b7b5fb93
    • Markus Reiter's avatar
      Fix style. · f6e7a3ed
      Markus Reiter authored
      f6e7a3ed
    • Markus Reiter's avatar
      Add `$LOAD_PATH` for RuboCop cops. · 444e3d2a
      Markus Reiter authored
      444e3d2a
    • Gautham Goli's avatar
      Merge pull request #4770 from GauthamGoli/style-results-npe-fix-3 · 0af24cf8
      Gautham Goli authored
      style: Fix npe and add test for corrected offense results
      Unverified
      0af24cf8
    • Gautham Goli's avatar
  4. Aug 28, 2018
  5. Aug 27, 2018
  6. Aug 26, 2018
Loading