The existing case-statement with nested if-statements is gross and hard
to extend. Replacing it with a priority queue simplifies the logic and
makes it very easy to add new compilers to the fails_with system, which
we will likely want to do in the future.

The original constraints that led to using a custom collection rather
than Array or Set here no longer exist, so let's avoid the pointless
abstraction here.

Closes Homebrew/homebrew#18520.

We want the new-style "/archive/" downloads.

* Add url check for GitHub home pages using http.
* Add url check for GitHub repo urls using http.
* Include url in error messages about url issues.

Closes Homebrew/homebrew#18372.

Closes Homebrew/homebrew#18481.

Added an option to linkapps to allow linking to /Applications rather
than ~/Applications

Closes Homebrew/homebrew#18196.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

Closes Homebrew/homebrew#17911.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

Given the current state of OS X compilers, the original fails_with
behavior is becoming less useful, mostly resulting in build failures
each time the compiler is updated. So make the following changes:

When a build is specified, we retain the old behavior: switch compilers
if the available compiler is <= the build, don't switch if it is > the
build.

When no build is specified, unconditionally switch compilers, and don't
output the advice message. This allows us to mark formulae as
perpetually failing, avoiding the need to update formulae each time a
new compiler build is made available.

As a bonus, this makes the logic much easier to reason about.

Closes Homebrew/homebrew#18175.

This reverts commit d72901f92b7385d44d8c980976db6a4336572e7e.

References Homebrew/homebrew#18366.
Closes Homebrew/homebrew#18432.

Currently `brew tap` only works on repos with 'homebrew-' in their name.

This version tries the repo name as is and then falls back to try
'homebrew-repo' only if that fails.

I've also tweaked the regex  in tap_args to allow '-' in repo names. The
previous regex required a match on \w. This made it impossible for people
to tap repos with names like 'username/why-not'.

Closes Homebrew/homebrew#18366.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

IO#read does not raise EOFError, it just returns an empty string for
each call after it consumes the underlying file or stream.

This module is going to be refactored and the begin/rescue is going to
be removed anyway.

This has two parts:

1. Bottles are temporarily relocated on bottling and tested if that is
sufficient for them to contain no longer reference the prefix or
cellar. If so, they are marked as relocatable.
2. On installation if bottles are marked as relocatable they will be
relocated using install_name_tool to the current prefix and cellar.

Closes Homebrew/homebrew#18374.

Closes Homebrew/homebrew#16344.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Needed for Linux compatibility.

Allows access to the Ruby path. Needed for Linux
porting.

Closes Homebrew/homebrew#18404.

Likely fixes Homebrew/homebrew#18324.

This fixes a false positive for mongodb.

Closes Homebrew/homebrew#18370.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

Closes Homebrew/homebrew#18371.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

These are redefined later for use in the bottle DSL.

This makes it easy to test things that vary depending on this constant
without editing testing_env.rb.

Fixes Homebrew/homebrew#18367.

Closes Homebrew/homebrew#18333.

has_trailing_newline? checked if formula did not have a trailing
newline. Invert regex and invert audit check.

Closes Homebrew/homebrew#18359.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

We keep rejecting this again and again.

See discussion in Homebrew/homebrew#9577, Homebrew/homebrew#12941, Homebrew/homebrew#13855.

Closes Homebrew/homebrew#18332.