Closes Homebrew/homebrew#43313.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#43259.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

Fixes test-bot mishandling of optional cross-tap dependencies. Without
this change, since formula.stable.deps includes the optional dependencies but
formula.recursive_dependencies does not, test-bot was trying to select a
compiler for an untapped formula, which raised an error.

Our suspect handling of optional dependencies was exposed by Homebrew/homebrew#43145 /
7184348e822d6745d8a103de104ff9626536bf1e.

Closes Homebrew/homebrew#43237.

Closes Homebrew/homebrew#43283.

Closes Homebrew/homebrew#43298.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Closes Homebrew/homebrew#43154.

Closes Homebrew/homebrew#43277.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Long term it would be nice to sandbox everything that writes to DerivedData
but it is essentially a cache directory of sorts.

The downside of allowing stuff to write there particularly is that DerivedData
is notoriously bad at getting cleaned up, so if you do a lot of Xcode-using
installations very quickly, you can chew your disk space up.

Closes Homebrew/homebrew#43276.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Use an exponential back-off on the sleep and try the fetch more times.

Hopefully this will mean that we spent less time waiting for Bintray.

Closes Homebrew/homebrew#43240.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#43273.

Signed-off-by: Tim D. Smith <git@tim-smith.us>

Closes Homebrew/homebrew#43260.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

It's already covered by `$?.exitstatus == 0` in below.

HOMEBREW_VERSION doesn't change very often; the repository state is more
interesting.

Closes Homebrew/homebrew#41886.

Fixes Homebrew/homebrew#43206.

Closes Homebrew/homebrew#41267.

Closes Homebrew/homebrew#43199.

Signed-off-by: Alex Dunn <dunn.alex@gmail.com>

Sometimes we accidentally install files outside prefix. After we fix that,
users will get nasty link conflict error. So we create a whitelist here to
allow overwriting certain files. e.g.
  link_overwrite "bin/foo", "lib/bar"
  link_overwrite "share/man/man1/baz-*"

During FormulaInstaller#link, the whitelist conflict files will be
backup into HOMEBREW_CACHE/Backup

Providing specific reference to the --strict option for brew audit.

Closes Homebrew/homebrew#43155.
Closes Homebrew/homebrew#43156.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Formula#bottle_specification always exists, while Formula#bottle only
exists if the bottle is available and compatible.

Merge branch 'bottle_hooks'

add testball_bottle formula for upcoming bottle unit testing, as well
as bottles directory containing test bottle (and symlinks)

add guard in Formula#file_modified? to prevent git popup

add guard in Superenv.bin before calling MacOS::Xcode.version

add guard against missing Xcode/CLT in Xcode.uncached_version

return nil instread of 0 in uncached_version when Xcode/CLT are not present, to distinguish from linuxbrew behavior

checks against pour_bottle? and needs_relocation?, add guard around keg.relocate_install_names to check pour_bottle?/needs_relocation? as well

needs_relocation? becomes skip_relocation?, use cellar attr to indicate relocation instead of does_not_need_relocation

MacOS.can_build? becomes MacOS.has_apple_developer_tools?

remove unneeded definition

change variable in FormulaInstaller.check_build_flags from bf to build_flags

Add these new errors, and guards in formula installation and
cmd/{,un,re}install to match, move can_build? to the MacOS module,
flatten conditions, remove redundant can_build? check

reinstate removed (doctor) check

This is so so that check_dependencies_bottled can be called when bottles
are being poured; implement check_dependencies_bottled

This becomes MacOS.{install_name_tool,otool}, only do check_xcode if
xcode is installed, otherwise emit a warning