Apaprently both expat.framework and libexpat.framework exist
and interfere with CMake.

The Fortran regex only allowed for trailing whitespace after:

    depends_on 'gfortran'

This missed conditional dependencies, such as:

    depends_on 'gfortran' if something?

Such a dependency was present in the NetCDF formula.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

Existing method moved to compatibility layer.

SourceForge links can end with /download which appears to be part of
what is used to drive mirror selection. Modifying the version detection
extension of pathname.rb to detect this case for both sourceforge.net
and sf.net download selections.

This is sufficient for version detection but may not be sufficient for
other uses of /download links. I have not found any problems with links
that use /download, though.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

When running `brew up`, if a mentioned formulae is also installed,
it will get a wildcard start at the end.
It makes it easier to see if any installed formulae is impacted.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

cols is calculated in the function body

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

This removes the single use of 'brew audit --warn' and
changes it to --strict as well.

xcodebuild should be passed an explicit SYMROOT, since the user
can override this.

Also added --strict, so certain audits can be ignored in most
cases (including this one.)

If an install fails, the ENV dump at the end of the output is more
useful, as it reflects any ENV changes done in def install.

* may be a problem if the constant is scoped (like A::B), but this is not the case
  (const.split('::').inject(Object) { |c, part| c.const_get part } would solve that)
* this was noticed in a comment of 9afc85ad but it has disappeared

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

Using popen here breaks brew install -v due to the way
the error pipe is passed around during install.

Moved snow_leopard_64? to compatibility and replaced it with
a function MacOS.prefer_64_bit?. This method is in a better
place and has a better name once Lion comes out.

Fixes Homebrew/homebrew#4710

Closes Homebrew/homebrew#4693.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>