Previously if I did `brew install boxen/brews/imagemagick` and then `brew
upgrade boxen/brews/imagemagick` and the version of `imagemagick` in
`boxen/brews` was older than the version in `Homebrew/homebrew` then it would
install the correct version from the `boxen/brews` tap and then try to
immediately upgrade it to the version from `Homebrew/homebrew`. I'd argue
fairly strongly that this behaviour is pretty unintuitive; when you fully
specify a formula from a tap then it should be prioritised by `brew upgrade`
and `brew outdated.

This commit makes `brew upgrade boxen/brews/imagemagick` only upgrade the
version of `imagemagick` if the version in the `boxen/brews` tap is newer.
Similarly `brew outdated imagemagick` and `brew outdated
boxen/brews/imagemagick` will show different results if the newer version
differs between `boxen/brews` and `Homebrew/homebrew`.

Closes Homebrew/homebrew#36699.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#36730.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

`ARGV.flag?` = `ARGV.include?` + `ARGV.switch?`

Closes Homebrew/homebrew#36727.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Also add support to `brew uses` to ignore build or optional dependencies.

Closes Homebrew/homebrew#36154.
Closes Homebrew/homebrew#36656.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

I feel like we’re probably fighting a losing battle here, but here’s a
bundle more updates to the example formula to cover some ground not
already covered.

Closes Homebrew/homebrew#36644.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Fixes Homebrew/homebrew#36217.

This is causing submodules to be checked out into a path with a literal
"$path" component:

$ find . | grep "\$path$"
./$path
./Carthage/Checkouts/Commandant/$path
./Carthage/Checkouts/Commandant/Carthage/Checkouts/Quick/$path
./Carthage/Checkouts/PrettyColors/$path
./Carthage/Checkouts/Quick/$path
./Carthage/Checkouts/ReactiveCocoa/$path
./Carthage/Checkouts/ReactiveCocoa/Carthage/Checkouts/Quick/$path
./Carthage/Checkouts/ReactiveTask/$path
./Carthage/Checkouts/ReactiveTask/Carthage/Checkouts/Quick/$path
./Carthage/Checkouts/ReactiveTask/Carthage/Checkouts/ReactiveCocoa/$path
./Carthage/Checkouts/ReactiveTask/Carthage/Checkouts/ReactiveCocoa/Carthage.checkout/Quick/$path

This reverts commit 3a5f099297e9ab3b799af5f7a65edd8d64bc7bae.

Before:

    $ brew info llvm
    ==> Dependencies
    Build: xz ✔️, xz ✔️, xz ✔️, xz ✔️, xz ✔️, xz ✔️

    $ brew info --json=v1 llvm
    ... "dependencies":["xz","xz","xz","xz","xz","xz"], ...

After

    $ brew info llvm
    ==> Dependencies
    Build: xz ✔️



    $ brew info --json=v1 llvm
    ... "dependencies":["xz"], ...

Closes Homebrew/homebrew#36653.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

for issue Homebrew/homebrew#36646

Closes Homebrew/homebrew#36649.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

See
https://github.com/Homebrew/homebrew/pull/36629#discussion_r24293912


amongst other recent examples. The example formula isn’t as strongly
policed as the ` brew create ` default, this tries to do something
about that.

Closes Homebrew/homebrew#36639.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Losslessly compress with jpegoptim and optipng.

Closes Homebrew/homebrew#36606.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

https://github.com/Homebrew/homebrew-brewdler/pull/43#discussion_r24248760



Closes Homebrew/homebrew#36611.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Fixes Homebrew/homebrew#35382.

This probably doesn't matter in practice, but I don't want to take any
chances.

Fixes Homebrew/homebrew#36335.

It shadows system headers sometimes (probably just Server.app?) but we don't
really care.

Don't match `help` at the end of every string because `brew installhelp`
shouldn't really be running help.

Closes Homebrew/homebrew#36559.
Closes Homebrew/homebrew#36576.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Update advice about easy-install.pth files.

Closes Homebrew/homebrew#36547.

e.g. devel-only or head-only formulae.

Since pyenv v20141211, it bundles built-in pip-rehash feature.

Closes Homebrew/homebrew#36524.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Fixes Homebrew/homebrew#36484.

This commits adds support for updating a formula with changed git
submodules with GitDownloadStrategy when the cloned repository is still
in the cache. This is done by running git submodule sync --recursive
before updating the submodules, so that git can reload the submodule
config from the updated .gitmodules file.

Fixes Homebrew/homebrew#36395.
Closes Homebrew/homebrew#36466.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

We want the apr requirement to act as a build-time requirement in case
it is satisfied (that is, the CLT is installed), as the resulting
binaries will link to the system libapr which is always present.

When it is *not* satisfied by the CLT, and we need to install the
formula, we have to treat it as a runtime dependency since the resulting
binaries will link to it.

Fixes Homebrew/homebrew#36301.
Fixes Homebrew/homebrew#36438.
Closes Homebrew/homebrew#36443.

If apr is installed, we still want to grab it during dependency
resolution in case we need to pass options to the generated dependency.

In other words, it doesn't make sense for the satisfiable condition to
include the default formula, as the default formula is the fallback for
when the requirement is *not* satisfied.

Requirements with default formulae cannot fail the build.

This matches the recommendation in the message.