Skip to content
Snippets Groups Projects
Unverified Commit f64e1fcf authored by Mike McQuaid's avatar Mike McQuaid
Browse files

Maintainer-Guidelines: give maintainers time to review enhancements.

Let's slow down a little on enhancement PRs to give other maintainers
time to give their feedback.

This is mostly self-directed criticism.
parent 1f6c1e97
No related branches found
No related tags found
No related merge requests found
......@@ -157,6 +157,16 @@ Any maintainer can merge any PR they have carefully reviewed and is passing CI t
Any maintainer can revert a PR created by another maintainer after a user submitted issue or CI failure that results. The maintainer who created the original PR should be given no less than an hour to fix the issue themselves or decide to revert the PR themselves if they would rather.
### Give time for other maintainers to review
PRs that are an "enhancement" to existing functionality i.e. not a fix to an open user issue/discussion, not a version bump, not a security fix, not a fix for CI failure, a usability improvement, a new feature etc. should wait 24h Monday - Friday before being merged. For example,
- a new feature PR submitted at 5pm on Thursday should wait until 5pm on Friday before it is merged
- a usability fix PR submitted at 5pm on Friday should wait until 5pm on Monday before it is merged
- a user-reported issue fix PR can be merged immediately after CI is green
If a maintainer is on holiday/vacation/sick during this time and leaves comments after they are back: please treat post-merge PR comments and feedback as you would left within the time period and follow-up with another PR to address their requests (if agreed).
## Communication
Maintainers have a variety of ways to communicate with each other:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment