diff --git a/docs/Maintainer-Guidelines.md b/docs/Maintainer-Guidelines.md index fd5a61b8624338a2f58e2d5567215b194f1c5411..3665570e508ee81b420e9ae2258e66b1a99c7965 100644 --- a/docs/Maintainer-Guidelines.md +++ b/docs/Maintainer-Guidelines.md @@ -157,6 +157,16 @@ Any maintainer can merge any PR they have carefully reviewed and is passing CI t Any maintainer can revert a PR created by another maintainer after a user submitted issue or CI failure that results. The maintainer who created the original PR should be given no less than an hour to fix the issue themselves or decide to revert the PR themselves if they would rather. +### Give time for other maintainers to review + +PRs that are an "enhancement" to existing functionality i.e. not a fix to an open user issue/discussion, not a version bump, not a security fix, not a fix for CI failure, a usability improvement, a new feature etc. should wait 24h Monday - Friday before being merged. For example, + +- a new feature PR submitted at 5pm on Thursday should wait until 5pm on Friday before it is merged +- a usability fix PR submitted at 5pm on Friday should wait until 5pm on Monday before it is merged +- a user-reported issue fix PR can be merged immediately after CI is green + +If a maintainer is on holiday/vacation/sick during this time and leaves comments after they are back: please treat post-merge PR comments and feedback as you would left within the time period and follow-up with another PR to address their requests (if agreed). + ## Communication Maintainers have a variety of ways to communicate with each other: