Skip to content
Snippets Groups Projects
Commit 2c370f36 authored by Mike McQuaid's avatar Mike McQuaid
Browse files

audit: check for more universal usage.

Also check for `ENV.universal_binary` and `build.universal?`. The prior
is still required for `wine` and the latter should never be required any
longer.
parent 4d6e3199
No related branches found
No related tags found
No related merge requests found
...@@ -1049,6 +1049,14 @@ class FormulaAuditor ...@@ -1049,6 +1049,14 @@ class FormulaAuditor
problem "Use ENV instead of invoking '#{$1}' to modify the environment" problem "Use ENV instead of invoking '#{$1}' to modify the environment"
end end
if formula.name != "wine" && line =~ /ENV\.universal_binary/
problem "macOS has been 64-bit only since 10.6 so ENV.universal_binary is deprecated."
end
if line =~ /build\.universal\?/
problem "macOS has been 64-bit only so build.universal? is deprecated."
end
if line =~ /version == ['"]HEAD['"]/ if line =~ /version == ['"]HEAD['"]/
problem "Use 'build.head?' instead of inspecting 'version'" problem "Use 'build.head?' instead of inspecting 'version'"
end end
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment