Skip to content
Snippets Groups Projects
Unverified Commit 20311aec authored by Dominyk Tiller's avatar Dominyk Tiller
Browse files

audit: flag redundant shell_output() exit codes

parent 8f3a80b5
No related branches found
No related tags found
No related merge requests found
......@@ -803,6 +803,10 @@ module Homebrew
problem "Use separate make calls" if line.include?("make && make")
if line =~ /shell_output\(['"].+['"], 0\)/
problem "Passing 0 to shell_output() is redundant"
end
if line =~ /JAVA_HOME/i && !formula.requirements.map(&:class).include?(JavaRequirement)
problem "Use `depends_on :java` to set JAVA_HOME"
end
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment