diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index a0104244a8efc555f0d35b72c20ab71f9f54a627..8818bf24743f606e3dcc739184dfc70299ea6f8e 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -803,6 +803,10 @@ module Homebrew problem "Use separate make calls" if line.include?("make && make") + if line =~ /shell_output\(['"].+['"], 0\)/ + problem "Passing 0 to shell_output() is redundant" + end + if line =~ /JAVA_HOME/i && !formula.requirements.map(&:class).include?(JavaRequirement) problem "Use `depends_on :java` to set JAVA_HOME" end