- Aug 04, 2020
-
-
Vladimir Goncharov authored
-
Vladimir Goncharov authored
-
Vladimir Goncharov authored
-
Vladimir Goncharov authored
-
Vladimir Goncharov authored
-
Vladimir Goncharov authored
-
Vladimir Goncharov authored
This PR adds matchers that accept a callable and verify that when invoked, it throws an exception with the given type and properties. Fixes #952
-
- Jul 29, 2020
-
-
Abseil Team authored
Internal documentation change. PiperOrigin-RevId: 323612305
-
ofats authored
Stop using ADL for InvokeArgument action. PiperOrigin-RevId: 323234396
-
- Jul 16, 2020
-
-
ofats authored
Move matchers' tests from *generated* to common files. PiperOrigin-RevId: 320954068
-
- Jul 10, 2020
-
-
ofats authored
Replace ByRef with std::ref everywhere in docs. PiperOrigin-RevId: 320002303
-
Abseil Team authored
Cleanup: Error message grammar fix. PiperOrigin-RevId: 319992912
-
Abseil Team authored
Fix mismatch between `int` and `int32_t` in the parse function. On some platforms, those are different types. PiperOrigin-RevId: 319991862
-
- Jul 06, 2020
-
-
Abseil Team authored
Improve compatibility with strict compilers targeting Windows Remove an unnecessary ##, which could result in warnings about invalid preprocessor tokens when pasting to an initial '(' PiperOrigin-RevId: 319277617
-
- Jun 27, 2020
-
-
Abseil Team authored
Normalize headers in gMock docs Increasing Header levels on two pages, to better match other pages in the same directory. PiperOrigin-RevId: 318280892
-
Abseil Team authored
Update auto_mock to support C++17 nested namespaces PiperOrigin-RevId: 318192214
-
- Jun 16, 2020
-
-
Abseil Team authored
gMock Cookbook: Fix incorrect comment about EXPECT priority order It's actually the last matching expectation that's used, not the first. PiperOrigin-RevId: 316490770
-
- Jun 11, 2020
-
-
Abseil Team authored
Change string matchers, like HasSubstr, to accept `string_view` input if available. PiperOrigin-RevId: 315726484
-
- Jun 05, 2020
-
-
Abseil Team authored
gMock Cookbook: Slight rewording Remove "I" because documentation can have multiple authors. And remove unnecessary "guy". PiperOrigin-RevId: 314533746
-
- Jun 03, 2020
-
-
Abseil Team authored
Note that EXPECT_EQ(actual_value, expected_value) or EXPECT_THAT(actual_value, Eq(expected_value)) is preferred over EXPECT_THAT(actual_value, expected_value). PiperOrigin-RevId: 314350852
-
- May 29, 2020
-
-
dmauro authored
Rollback of warning on unused ACTION result change PiperOrigin-RevId: 313380971
-
Abseil Team authored
Spell out namespace for absl::Notification. PiperOrigin-RevId: 312300192
-
durandal authored
Silence MSVC C4100 (unused formal parameter) to fix breakage from recently added testcase. This warning is silenced in many files throughout googletest, but was not needed here until this testcase was added. PiperOrigin-RevId: 312121200
-
Abseil Team authored
Mark ACTION_Pn()-generated functions as must-use-result. This catches when a client creates an action and discards it, thinking that the action has actually been applied to something. This will help people who make the mistake of defining, for example, both `void Use(Foo*)` and `ACTION(Use) { Use(arg); }` for later application to a Foo. With such an overload, a client may then write `Use();`, forgetting the param and being confused why nothing happens. This also catches when a client defines their own action in terms of an ACTION()-generated one, invokes the ACTION's builder, and then fails to invoke the resulting action, thinking it's operating on the outer action's parameters. PiperOrigin-RevId: 312108101
-
Abseil Team authored
Fix the ACTION* macros to allow for more than 10 arguments in the action. Only the first 10 will be passed as individual arguments as `argN`, but the rest can be accessed from the `args` tuple. PiperOrigin-RevId: 311542098
-
- May 13, 2020
-
-
Abseil Team authored
Addresses https://github.com/google/googletest/pull/2784 PiperOrigin-RevId: 310902202
-
- May 08, 2020
-
-
Abseil Team authored
Fix `-Wgnu-zero-variadic-macro-arguments` in GMock Passing zero arguments to the variadic part of a macro is a GNU extension and triggers warnings when build projects using GMock with `-pedantic`. - Fix uses of `GMOCK_PP_INTERNAL_16TH` to always receive at least 17 arguments. (this was triggered when `GMOCK_PP_NARG` or `GMOCK_PP_HAS_COMMA` were used with an argument containing no commas). - Fix `GMOCK_PP_HEAD` to append a dummy unused argument so that `GMOCK_PP_INTERNAL_HEAD` always has two arguments. PiperOrigin-RevId: 310414611
-
- May 02, 2020
-
-
Abseil Team authored
Fix link to "high-perf dependency injection technique". PiperOrigin-RevId: 308893893
-
Abseil Team authored
internal change PiperOrigin-RevId: 308648034
-
Abseil Team authored
Rewrite ReturnNew action without using pump. PiperOrigin-RevId: 308219616
-
Abseil Team authored
Fix comment that describes how to test against nullopt. PiperOrigin-RevId: 307448375
-
- May 01, 2020
-
-
keshavgbpecdelhi authored
There is an unnecessary comma before 'and'
-
- Apr 24, 2020
-
-
Arthur O'Dwyer authored
gmock-spec-builders.h:503:3: error: definition of implicit copy constructor for 'Expectation' is deprecated because it has a user-declared destructor [-Werror,-Wdeprecated] ~Expectation(); ^
-
Arthur O'Dwyer authored
None of these are strictly needed for correctness. A large number of them (maybe all of them?) trigger `-Wdeprecated` warnings on Clang trunk as soon as you try to use the implicitly defaulted (but deprecated) copy constructor of a class that has deleted its copy assignment operator. By declaring a deleted copy assignment operator, the old code also caused the move constructor and move assignment operator to be non-declared. This means that the old code never got move semantics -- "move-construction" would simply call the defaulted (but deprecated) copy constructor instead. With the new code, "move-construction" calls the defaulted move constructor, which I believe is what we want to happen. So this is a runtime performance optimization. Unfortunately we can't yet physically remove the definitions of these macros from gtest-port.h, because they are being used by other code internally at Google (according to zhangxy988). But no new uses should be added going forward.
-
- Apr 17, 2020
-
-
Arthur O'Dwyer authored
We are about to remove all uses of GTEST_DISALLOW_ASSIGN_ in favor of using the Rule of Zero everywhere. Unfortunately, if we use the Rule of Zero here, then when the compiler needs to figure out if VariadicMatcher is move-constructible, it will recurse down into `tuple<Args...>`, which on libstdc++ recurses too deeply. In file included from googlemock/test/gmock-matchers_test.cc:43: In file included from googlemock/include/gmock/gmock-matchers.h:258: In file included from /usr/include/c++/5.5.0/algorithm:60: In file included from /usr/include/c++/5.5.0/utility:70: In file included from /usr/include/c++/5.5.0/bits/stl_pair.h:59: In file included from /usr/include/c++/5.5.0/bits/move.h:57: /usr/bin/include/c++/5.5.0/type_traits:115:26: fatal error: recursive template instantiation exceeded maximum depth of 256 : public conditional<_B1::value, _B1, _B2>::type ^ The move constructor is the only problematic case, for some unknown reason. With GTEST_DISALLOW_ASSIGN_, the presence of a copy assignment operator causes the move constructor to be non-declared, thus non-defaulted, thus non-problematic. Without GTEST_DISALLOW_ASSIGN_, we have to do one of the following: - Default the copy constructor, so that the move constructor will be non-declared. - Define our own non-defaulted move constructor. ...except that doing the latter STILL did not work! Fortunately, the former (default the copy constructor, don't provide any move constructor) both works in practice and is semantically equivalent to the old code.
-
Abseil Team authored
Fix link to "After clause". Sorry, reader, but this heading is in another document! PiperOrigin-RevId: 305947971
-
- Apr 01, 2020
-
-
Abseil Team authored
Do not use std::result_of as it was removed in C++20. PiperOrigin-RevId: 303783600
-
- Mar 21, 2020
-
-
Neal Gompa authored
Google Test and Google Mock require matching versions to work, so this requirement should be described in the pkgconfig files. This change is derived from the one used for the Fedora gtest package. Signed-off-by:
Neal Gompa <ngompa13@gmail.com>
-
Neal Gompa authored
When building packaged shared libraries for use, having the version set makes it so that the soname is set correctly for parallel installation. This change is derived from the one used for the Fedora gtest package. Signed-off-by:
Neal Gompa <ngompa13@gmail.com>
-
Abseil Team authored
Internal change PiperOrigin-RevId: 302048013
-