Skip to content
  • Levi Tamasi's avatar
    BlobDB: only compare CF IDs when checking whether an API call is for the default CF (#6226) · 7a7ca8eb
    Levi Tamasi authored
    Summary:
    BlobDB currently only supports using the default column family. The earlier
    code enforces this by comparing the `ColumnFamilyHandle` passed to the
    `Get`/`Put`/etc. call with the handle returned by `DefaultColumnFamily`
    (which, at the end of the day, comes from `DBImpl::default_cf_handle_`).
    Since other `ColumnFamilyHandle`s can also point to the default column
    family, this can reject legitimate requests as well. (As an example,
    with the earlier code, the handle returned by `BlobDB::Open` cannot
    actually be used in API calls.) The patch fixes this by comparing only
    the IDs of the column family handles instead of the pointers themselves.
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/6226
    
    Test Plan: `make check`
    
    Differential Revision: D19187461
    
    Pulled By: ltamasi
    
    fbshipit-source-id: 54ce2e12ebb1f07e6d1e70e3b1e0213dfa94bda2
    7a7ca8eb