Closes Homebrew/homebrew#45443.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

Fixes Homebrew/homebrew#45414

Closes Homebrew/homebrew#45420.

Signed-off-by: Xu Cheng <xucheng@me.com>

see Homebrew/homebrew-emacs#29

Closes Homebrew/homebrew#45426.

Signed-off-by: Alex Dunn <dunn.alex@gmail.com>

Closes Homebrew/homebrew#45254.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Fixes Homebrew/homebrew#45310.

Closes Homebrew/homebrew#45336.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

Feature it a bit more prominently in the documentation as a result.

Closes Homebrew/homebrew#45374.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

There's been a few issues where users have been confused about these
errors. They may have modified stuff but we probably don't care about
telling them that unless we're debugging other issues.

Closes Homebrew/homebrew#45373.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#45337.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

Until a point in time when the Cask/Homebrew codebases are harmonised a little
more it probably makes sense to refuse to `cat` Casks. Right now the Homebrew
codebase is only minimally aware of what a Cask is.

Fixes Homebrew/homebrew#45300.
Fixes Homebrew/homebrew#44630.

Closes Homebrew/homebrew#45302.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

`Pathname#children(with_directory = false)` doesn't filter directories,
instead it returns path with basename.

Closes Homebrew/homebrew#45325.

Signed-off-by: Xu Cheng <xucheng@me.com>

Closes Homebrew/homebrew#45266.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

* Checks for placement of the bottle modifier variable.

* Checks there isn't a bottle modifier and a bottle do block - The former makes
the latter redundant.

Closes Homebrew/homebrew#45146.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Closes Homebrew/homebrew#45263.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>

This prevents typos like `bottle :uneeded` or `bottle :disable`

Closes Homebrew/homebrew#45264.

Signed-off-by: Xu Cheng <xucheng@me.com>

Provide `OS::Mac.prerelease?` for pre-release checks and use it where
appropriate. This should simplify updating the test once a new OS X
release lands.

This also fixes a bug in `BuildError#dump`, where an empty warning
message was printed on El Capitan after a failed from-source build,
because the check there and the one in `check_for_unsupported_osx` were
out of sync.

Closes Homebrew/homebrew#45257.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Fixes Homebrew/homebrew#44061.
Closes Homebrew/homebrew#44501.
Closes Homebrew/homebrew#45108.

Signed-off-by: Alex Dunn <dunn.alex@gmail.com>

We don't care about the formulae that have changed since the last commit
so just ignore it.

`Keg#app_installed?` only checks the formula prefix and `libexec/` for
.app bundles to determine if a formula provides any. This is used by
`Caveats#app_caveats` to generate an appropriate message. The same list
should be used by `brew linkapps` for consistency.

Reduce likelihood of future inconsistencies by creating `Keg#apps` and
using it in place of the duplicate code.

Closes Homebrew/homebrew#45173.

Signed-off-by: Xu Cheng <xucheng@me.com>

Closes Homebrew/homebrew#45175.

Signed-off-by: Xu Cheng <xucheng@me.com>

Use `start_with?` to make sure the symlink actually points into one of
the Homebrew directories (depending on given arguments). Previously,
only a substring match was used, which would also remove a symlink to a
hypothetical `/opt/unrelated/usr/local/opt/Unrelated.app`. Even if
unlikely to occur, altering stuff unrelated to Homebrew is bad.

Furthermore, make sure to always use a trailing slash with directories.
Otherwise, e.g., `brew unlinkapps qt` will unlink .app bundles of both
`qt` and `qt5` if both are installed and `brew linkapps qt qt5` was
issued before. (Please ignore that `qt` and `qt5` offer a conflicting
set of .app bundles. This will have to be addressed elsewhere.)

Closes Homebrew/homebrew#45174.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#45134.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#43935.

Signed-off-by: Xu Cheng <xucheng@me.com>

Also don't pour bottle if it's disabled.

Closes Homebrew/homebrew#42222.
Closes Homebrew/homebrew#44892.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

`reinstall` can currently be executed under sudo and has every chunk of problems
running install under sudo does when `brew` isn't root owned.

Likewise with `postinstall` which we increasingly use to create directories and
move/install files elsewhere. Using sudo there both masks deeper issues and
makes uninstall troublesome.

Closes Homebrew/homebrew#45112.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>

Closes Homebrew/homebrew#45021.

Signed-off-by: Xu Cheng <xucheng@me.com>

Closes Homebrew/homebrew#44988.

Signed-off-by: Xu Cheng <xucheng@me.com>