`brew linkapps` was creating `MacVim` on the first run, then
`MacVim alias` on the second run.

Closes Homebrew/homebrew#14955.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

Rescuing false on the StandardCompilers map meant that the doctor
check assumed that the compilers were incorrect, not merely
unknown.

Instead, skip the check and return nil for unknown Xcode; nil
should be interpreted as "dunno", instead of "true" or "false",
and the doctor check no longer prints on nil.

We now have several reports of compiler versions for the GM,
e.g. Homebrew/homebrew#14944.

Oops.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Closes Homebrew/homebrew#14654.

build-tool provided args must be considered first by cc, etc. Generally this already occurred for -I flags, because most of our -I flags were -isystem. However it didn't occur for keg-only flags and -L paths.

This was an error.

I amended the refurbishment code to ensure any paths we want to control the order of are thoroughly scrubbed out of the build-tool provided args. This ensures reliability for our builds.

However this path-scrubbing should always occur, even during configure (I am fairly sure of this). So more work is required.

Fixes Homebrew/homebrew#14781.

The usual xcrun would, and this wrapper exists to also work around broken xcode-select paths.

Build rb should only build!

Because it builds a tool (cabal) that uses the same env that built it to build stuff.

Fixes Homebrew/homebrew#14780.

We can't really execute c89/99 explicitly as these POSIX compliant tools support very few args. Best to execute clang or gcc with the --std=cx9 argument appended.

Fixes Homebrew/homebrew#14724.

bsdmake used to be keg-only, so some users still have it unlinked (presumably they never run brew-doctor). Even though there is code to abort if dependencies are unlinked, it appears broken for this case. So let's just be thorough anyway.

Closes Homebrew/homebrew#14751.

/Developer/Library shouldn't exist if all the remnants of old
Xcode versions have been uninstalled, and tends to cause problems if
it's kept alongside modern Xcode.

"uninstall-developer-folder" should only remove /Developer/Library.

Sublime Text's subl tool supports lovely project views just the same
as TextMate. Since I use Sublime, I want good support from `brew
edit` too. :P

Fixes Homebrew/homebrew#14701. Stupid mistake.

Rationale: everyone thinks it points to the currently installed prefix, not the prefix of the formula that is newest and maybe not installed.

The previous behavior was unintentional and evidence proves it is not intuitive either.

I anticipate no regressions. And hope I am right!

Extend patch case statements for files to objects inheriting from `IO`, which
includes `File`, or `StringIO` which is used by the external command
`brew-unpack` to store `DATA` sections loaded from Formula files.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Fixes Homebrew/homebrew#14840.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

 - Avoid ENOTDIR by ensuring that the directories we are checking are
   actually directories.
 - DRY up the check_PATH method; paths are already available via the
   global ORIGINAL_PATHS.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Reword the `X11Dependency` error message so that it is clear that an installer
must be downloaded.

Ref Homebrew/homebrew#14851.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

The MacOS.version? family of methods (other than "leopard?") are poorly
defined and lead to confusing code. Replace them in formulae with more
explicit comparisons.

"MacOS.version" is a special version object that can be compared to
numerics, symbols, and strings using the standard Ruby comparison
methods.

The old methods were moved to compat when the version comparison code
was merged, and they must remain there "forever", but they should not be
used in new code.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Symlinks to apps don't play well with Spotlight, but Finder alises do,
so let's create them instead.

Closes Homebrew/homebrew#14821.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

The problem is not the raw URLs, but URLs that do not contain the commit
hash corresponding to a particular version of the gist.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

File.expand_path raises ArgumentError when it is passed a path with a
nonexistent username, e.g.:

  $ PATH=~foo/bin:$PATH brew
  /usr/local/Library/Homebrew/global.rb:97:in `expand_path': user foo
  doesn't exist (ArgumentError)

However, `brew doctor` does its own expansion of PATH entries and
outputs warnings if this happens, so let's just ignore it here and
continue on our way.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Fixes Homebrew/homebrew#14752.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>