This reverts commit bcd34ded9e4b17b8658b7ae947cd392a4e5942c0.

Closes Homebrew/homebrew#38658.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

v0.30.0 has killed a couple of the methods being used and is throwing
warnings around like candy. This switches to the new methods.

Rubocops are obviously a matter of choice, and I’ve added choice here
based on what was said in previous PRs and my own personal views on
readability. Happy to be told to change things to different variables.

For upstream detail, see:

*
https://github.com/bbatsov/rubocop/blob/master/relnotes/v0.30.0.md#chang
es
* https://github.com/bbatsov/rubocop/pull/1721/files
* https://github.com/bbatsov/rubocop/pull/1655/files



Closes Homebrew/homebrew#38655.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

At the moment, every time I pull a new formulae from a tap, I have to
fetch it with the fully qualified name, `brew fetch
homebrew/versions/duck123 `, which is fine, but then I also have to
install, test, and audit it in the same way, which isn’t fixed until I
tap repair, which gets a bit onerous.

This just adds a step to `brew pull` where it does the tap repair
automatically for taps.

Closes Homebrew/homebrew#37788.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#38571.

Closes Homebrew/homebrew#38570.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Otherwise e.g. --debug will be interpreted as a (bad) tap argument.

Closes Homebrew/homebrew#38569.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Without this, `brew audit <some formula>` may ask people to change:

    system "./script.sh foo-*"

into:

    system "./script.sh", "foo-*"

These are not the same. In the first example the shell expansion occurs
while it doesn’t in the second one, breaking the build.

Closes Homebrew/homebrew#38540.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Discussion: https://github.com/Homebrew/homebrew/issues/37945


Patch by @jacknagel.

Closes Homebrew/homebrew#38492.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

It’s Christmas. New stable OS X version, new Swift version, new Xcode,
new CLT and a new Clang version.

Closes Homebrew/homebrew#38468.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#38361.

Signed-off-by: Xu Cheng <xucheng@me.com>

Moves from None to Release, but comments out the standard release
CFLAGS so we can continue using our own.

Bumped Libgit2 as an example/test to play with.

Closes Homebrew/homebrew#37332, hopefully.

Closes Homebrew/homebrew#37361.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

brew deps will fail silently if a formula has dependencies which live in
taps that have not yet been tapped. Delay checking brew deps until after
tap dependencies are discovered.

Closes Homebrew/homebrew#38424.

test-bot expects the dependencies returned from SoftwareSpec#deps to
satisfy is_a?(TapDependency) if they come from a tap which might need to
be tapped.

Formulas that build python things and which are tested with system
Python will encounter test failures unless system Python is configured
to add Homebrew's site-packages to sys.path. This change makes sure that
configuration is performed in the test environment.

Both lines are needed; the first reads and processes .pth files and the
second makes sure that Homebrew's site-packages is read before the
system extras, so that formulas depending on Homebrew/python/numpy get
the Homebrew/python version and not the old system version.

Closes Homebrew/homebrew#38466.

This is a more standard way to pass fd in UNIX world.
At the same time, it helps to remove a few hacks and
simplifies the code in the sandbox.

Closes Homebrew/homebrew#38434.

Signed-off-by: Xu Cheng <xucheng@me.com>

Closes Homebrew/homebrew#38475.

Signed-off-by: Xu Cheng <xucheng@me.com>

Closes Homebrew/homebrew#37059.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#37057.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Per requirements.rb:

    >  XXX If the satisfy block returns a Pathname, then make sure that it
    >  remains available on the PATH. This makes requirements like
    >    satisfy { which("executable") }
    >  work, even under superenv where "executable" wouldn't normally be on the
    >  PATH.
    >  This is undocumented magic and it should be removed, but we need to add
    >  a way to declare path-based requirements that work with superenv first.

Fixes homebrew/homebrew-python#170.

Closes Homebrew/homebrew#38448.

This means e.g. `elixir` will show up as using `erlang`.

Closes Homebrew/homebrew#38457.

Signed-off-by: Xu Cheng <xucheng@me.com>

Closes Homebrew/homebrew#38439.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#38413.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#38404

This prevents a downgrade attack.

Closes Homebrew/homebrew#38433.

Signed-off-by: Xu Cheng <xucheng@me.com>

Fixes the bottle regex problem seen in
https://github.com/Homebrew/homebrew-versions/pull/678

.

I don’t know whether it’s a good regex, or an awful regex, but it works
and passes `brew tests` and a bottled install. Open to improvements if
anyone has them.

Closes Homebrew/homebrew#38333.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

by analogy to similar code in formula.rb.

Permits Homebrew/homebrew#37877. Closes Homebrew/homebrew#38330.

Excludes the PyPy paths from the unbrewed list, since we do the same
with Python.

Closes Homebrew/homebrew#38399.

changed from `brew --repository` to $(brew --repository)

Closes Homebrew/homebrew#38352.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Comparing PkgVersion and Version objects can produce nonsensical
results. For example, equality is not symmetric:

irb(main):002:0> PkgVersion.new("1.0", 0) == Version.new("1.0")
=> false
irb(main):003:0> Version.new("1.0") == PkgVersion.new("1.0", 0)
=> true

Rather than attempt to deal with subclass-superclass equality, let's use
composition and punt on the problem altogether.

Closes Homebrew/homebrew#38302.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>