At this point it's never a good compiler to use so let's just remove it.

Since `system` escapes its own spaces, cabal was interpreting
`--flags='webapp s3'` as `+'webapp +s3'` rather than `+webapp +s3`.

Closes #267.

Signed-off-by: ilovezfs <ilovezfs@icloud.com>

Used for uploading imagemagick 6.9.4-3.

There are unnecessarily verbose, have been documented to be avoided and
it’s good to nudge people towards the other style.

GitHub’s code load and patch-diff URLs are the result of redirects and
make it harder to modify the URL to reach the original repository.

Obvious copy/paste failure in acc9a7ca.

No need to source `cmd/update.sh` if `homebrew-update` is not going to
be called directly. Amends 750bb24a.

Closes #239.

Closes #228.

git is also used in analytics.sh

Preinstall update should be performed in a separate process,
so it can maintain and close its own update lock.

Closes #181.

Signed-off-by: Xu Cheng <xucheng@me.com>

a Bash implementation of lock using `flock(2)`.

The fix changes behavior in same cases, but those cases were all either
broken or showed unexpected behavior. The new behavior is very simple:

- If an argument starts with `--<option-name>=`, return whatever comes
  after the equals sign.

Prior to this change, `ARGV.value` showed some unexpected behavior:

- `ARGV.value("foo")` returned `nil` for `--foo=` because at least one
  character needed to be present after the equals sign. (All other
  option parser implementations I'm aware of allow for empty values.)

- `ARGV.value("bar")` returned `"baz"` for `--foo=--bar=baz` because the
  regular expression was not anchored to the start of the argument.

- `ARGV.value("++")` raised an exception because the string wasn't
  escaped for use in the regular expression. (An unlikely corner case.)

Closes #231.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>

When passing formula options with value, e.g. `--with-qt=5`, to the
child process responsible for building a formula, `ARGV.value` would be
invoked with `nil`. Handle this more elegantly (no change in behavior).

For consistency, use a regular expression adapted from `Options.create`
instead of the somewhat bogus one used before.

I'm not completely sure this is "sane" logic but I'm leery of just reverting
Andrew's work this morning and making him rebuild that PR from scratch for one
syntax issue.

Sadly, because we run:
```
brew readall --aliases --syntax
```
On every CI job, and that flags this line previously as:
```
pull.rb:555: warning: possibly useless use of a variable in void context
```

Every single PR has "failed" since it was merged, and it's reached the point
of being a bit annoying, so let's try this.

Works around issue with GET and HEAD apparently acting differently, and
bottle downloads failing even after successful polling completion.

Closes #1028.

Fix regression introduced in fafe8f0f.
Counting the number of hyphens in a string cannot be done in a single
expression, thus split this and introduce another local variable.

Fixes #227.

Fix regression introduced in fafe8f0f.

CPU was transformed into a class in 8d995e96.

The previous fixes in c6dc50fc and
ed9f7308 were incomplete as they
referenced `DeveloperTools`, but the actual name is `DevelopmentTools`.

Also fixes indentation and a broken `MacOS.clang_version` (it was
falsely redirecting to `DeveloperTools.llvm_build_version` ).

References #219.
References #220.

Closes #220.

Follow-up to c7edf9a0 and related to
changes from #168.

Closes #219.

Make sure `Regexp.escape` gets a string as Ruby 1.8 is unable to convert
the symbol to a string automatically. Related to changes from #168.

Partially addresses #219. Related to changes introduced in #168.

Closes #216.

Makes it easy to debug what’s gone wrong.