We haven't actually had any complaints about this in awhile; it appears
that cmake no longer picks up this specific framework.

Refs Homebrew/homebrew#11030.

If the build process tries to write more bytes than will fit in the pipe
buffer, it will block until the parent process does a read. However, the
parent process will only do a read after the child process has exited or
died, leading to a deadlock. Fix this by doing the read in a separate
thread.

:universal and :cxx11 are now handled directly, so we don't need to
always convert symbols to strings in this method. Symbols should be
reserved for future use.

This method is only used internally and we always pass strings.

This method is called in two places, always with two arguments.

Fixes Homebrew/homebrew#31360.

Closes Homebrew/homebrew#31384.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

For easier capturing.

Closes Homebrew/homebrew#31303.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

Closes Homebrew/homebrew#30540.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

The major version is implicit in the compiler name. Since the name is
used when matching failures to compilers, we don't need to consider the
major version separately.

major_version is now only used internally by the failure object