Merge pull request #8255 from nandahkrishna/migrate-livecheck-strategy

livecheck migration: add strategies

Library/Homebrew/test/livecheck/strategy/npm_spec.rb

+# frozen_string_literal: true
+
+require "livecheck/strategy/npm"
+
+describe Homebrew::Livecheck::Strategy::Npm do
+  subject(:npm) { described_class }
+
+  let(:npm_url) { "https://registry.npmjs.org/abc/-/def-1.2.3.tgz" }
+  let(:non_npm_url) { "https://brew.sh/test" }
+
+  describe "::match?" do
+    it "returns true if the argument provided is an npm URL" do
+      expect(npm.match?(npm_url)).to be true
+    end
+
+    it "returns false if the argument provided is not an npm URL" do
+      expect(npm.match?(non_npm_url)).to be false
+    end
+  end
+end

Library/Homebrew/test/livecheck/strategy/page_match_spec.rb

+# frozen_string_literal: true
+
+require "livecheck/strategy/page_match"
+
+describe Homebrew::Livecheck::Strategy::PageMatch do
+  subject(:page_match) { described_class }
+
+  let(:url) { "http://api.github.com/Homebrew/brew/releases/latest" }
+
+  describe "::match?" do
+    it "returns true for any URL" do
+      expect(page_match.match?(url)).to be true
+    end
+  end
+end

Library/Homebrew/test/livecheck/strategy/pypi_spec.rb

+# frozen_string_literal: true
+
+require "livecheck/strategy/pypi"
+
+describe Homebrew::Livecheck::Strategy::Pypi do
+  subject(:pypi) { described_class }
+
+  let(:pypi_url) { "https://files.pythonhosted.org/packages/ab/cd/efg/hij-1.2.3.tar.gz" }
+  let(:non_pypi_url) { "https://brew.sh/test" }
+
+  describe "::match?" do
+    it "returns true if the argument provided is a PyPI URL" do
+      expect(pypi.match?(pypi_url)).to be true
+    end
+
+    it "returns false if the argument provided is not a PyPI URL" do
+      expect(pypi.match?(non_pypi_url)).to be false
+    end
+  end
+end

Library/Homebrew/test/livecheck/strategy/sourceforge_spec.rb

+# frozen_string_literal: true
+
+require "livecheck/strategy/sourceforge"
+
+describe Homebrew::Livecheck::Strategy::Sourceforge do
+  subject(:sourceforge) { described_class }
+
+  let(:sourceforge_url) { "https://downloads.sourceforge.net/project/abc/def-1.2.3.tar.gz" }
+  let(:non_sourceforge_url) { "https://brew.sh/test" }
+
+  describe "::match?" do
+    it "returns true if the argument provided is a SourceForge URL" do
+      expect(sourceforge.match?(sourceforge_url)).to be true
+    end
+
+    it "returns false if the argument provided is not a SourceForge URL" do
+      expect(sourceforge.match?(non_sourceforge_url)).to be false
+    end
+  end
+end

Library/Homebrew/test/livecheck/strategy/xorg_spec.rb

+# frozen_string_literal: true
+
+require "livecheck/strategy/xorg"
+
+describe Homebrew::Livecheck::Strategy::Xorg do
+  subject(:xorg) { described_class }
+
+  let(:xorg_url) { "https://www.x.org/archive/individual/app/abc-1.2.3.tar.bz2" }
+  let(:non_xorg_url) { "https://brew.sh/test" }
+
+  describe "::match?" do
+    it "returns true if the argument provided is an X.Org URL" do
+      expect(xorg.match?(xorg_url)).to be true
+    end
+
+    it "returns false if the argument provided is not an X.Org URL" do
+      expect(xorg.match?(non_xorg_url)).to be false
+    end
+  end
+end

Library/Homebrew/test/livecheck/strategy_spec.rb

+# frozen_string_literal: true
+
+require "livecheck/strategy"
+
+describe Homebrew::Livecheck::Strategy do
+  subject(:strategy) { described_class }
+
+  describe "::from_symbol" do
+    it "returns the Strategy module represented by the Symbol argument" do
+      expect(strategy.from_symbol(:page_match)).to eq(Homebrew::Livecheck::Strategy::PageMatch)
+    end
+  end
+
+  describe "::from_url" do
+    let(:url) { "https://sourceforge.net/projects/test" }
+
+    context "when no regex is provided" do
+      it "returns an array of usable strategies which doesn't include PageMatch" do
+        expect(strategy.from_url(url)).to eq([Homebrew::Livecheck::Strategy::Sourceforge])
+      end
+    end
+
+    context "when a regex is provided" do
+      it "returns an array of usable strategies including PageMatch, sorted in descending order by priority" do
+        expect(strategy.from_url(url, regex_provided: true))
+          .to eq(
+            [Homebrew::Livecheck::Strategy::Sourceforge, Homebrew::Livecheck::Strategy::PageMatch],
+          )
+      end
+    end
+  end
+end