Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
B
brew
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to JiHu GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
KMSCAKKSCFKA AKFACAMADCAS
brew
Commits
d9790309
Commit
d9790309
authored
11 years ago
by
Jack Nagel
Browse files
Options
Downloads
Patches
Plain Diff
Fix SYMROOT audit
parent
f432a59f
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
Library/Homebrew/cmd/audit.rb
+10
-7
10 additions, 7 deletions
Library/Homebrew/cmd/audit.rb
with
10 additions
and
7 deletions
Library/Homebrew/cmd/audit.rb
+
10
−
7
View file @
d9790309
...
...
@@ -331,7 +331,14 @@ class FormulaAuditor
end
end
def
audit_text
(
line
)
def
audit_text
# xcodebuild should specify SYMROOT
if
text
=~
/system\s+['"]xcodebuild/
and
not
text
=~
/SYMROOT=/
problem
"xcodebuild should be passed an explicit
\"
SYMROOT
\"
"
end
end
def
audit_line
(
line
)
if
line
=~
/<(Formula|AmazonWebServicesFormula|ScriptFileFormula|GithubGistFormula)/
problem
"Use a space in class inheritance: class Foo <
#{
$1
}
"
end
...
...
@@ -423,11 +430,6 @@ class FormulaAuditor
problem
"Use spaces instead of tabs for indentation"
end
# xcodebuild should specify SYMROOT
if
line
=~
/system\s+['"]xcodebuild/
and
not
line
=~
/SYMROOT=/
problem
"xcodebuild should be passed an explicit
\"
SYMROOT
\"
"
end
if
line
=~
/ENV\.x11/
problem
"Use
\"
depends_on :x11
\"
instead of
\"
ENV.x11
\"
"
end
...
...
@@ -609,7 +611,8 @@ class FormulaAuditor
audit_deps
audit_conflicts
audit_patches
text
.
each_line
{
|
line
|
audit_text
(
line
)
}
audit_text
text
.
each_line
{
|
line
|
audit_line
(
line
)
}
audit_python
audit_installed
end
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment