Skip to content
Snippets Groups Projects
Commit d877fc0b authored by Alex Wang's avatar Alex Wang Committed by Mike McQuaid
Browse files

superenv: only strip sysroot flags for OS X SDKs.


Removing all sysroot flags is ok until a non-OS X SDK is needed. In
that case, builds can fail due to the non-OS X SDK being overwritten or
overridden by the OS X SDK.

Sysroot flags are now only stripped if they are an OS X SDK. This is
reliant on only OS X SDKs containing the string "macosx", so this will
break if if the wrong SDK shows up. However, the chances of that
happening seem low, as Apple probably doesn't want to introduce
something OS X that doesn't work with OS X, so it should be robust for
the near future.

This could break in an environment without the command line tools. The
fix for that is a bit more involved, though, so that will have to go
later.

Closes Homebrew/homebrew#44312.

Signed-off-by: default avatarMike McQuaid <mike@mikemcquaid.com>
parent ed42b2eb
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment