Skip to content
Snippets Groups Projects
Unverified Commit d550ed65 authored by Mike McQuaid's avatar Mike McQuaid
Browse files

Scheduled workflows fixes

- Ensure `spdx.yml` has same fixes as `tapioca.yml`.
- Don't `reset --hard` to ensure that `brew` commands used are those in
  the same branch rather than always from `origin/master`
- Don't check for an existing branch but instead force-push to it if
  there's any updates.
- Provide sample `brew typecheck` command that can be used.
parent a6744d2e
No related branches found
No related tags found
No related merge requests found
...@@ -25,16 +25,14 @@ jobs: ...@@ -25,16 +25,14 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
HOMEBREW_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} HOMEBREW_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: | run: |
cd "$GITHUB_WORKSPACE/Library/Homebrew" git fetch origin master
git reset origin/master
git checkout -B spdx-update
if brew update-license-data --fail-if-not-changed; then if brew update-license-data --fail-if-not-changed; then
if ! git ls-remote --exit-code --heads origin spdx-update; then git add "$GITHUB_WORKSPACE/Library/Homebrew/data/spdx"
git checkout -B spdx-update git commit -m "spdx: update license data." -m "Autogenerated by [a scheduled GitHub Action](https://github.com/Homebrew/brew/blob/master/.github/workflows/spdx.yml)."
git reset origin/master echo "::set-output name=committed::true"
git add data/spdx
git commit -m "spdx: update license data." -m "Autogenerated by [a scheduled GitHub Action](https://github.com/Homebrew/brew/blob/master/.github/workflows/spdx.yml)."
echo "::set-output name=committed::true"
fi
fi fi
- name: Push commits - name: Push commits
...@@ -43,11 +41,10 @@ jobs: ...@@ -43,11 +41,10 @@ jobs:
with: with:
token: ${{ secrets.HOMEBREW_GITHUB_API_TOKEN }} token: ${{ secrets.HOMEBREW_GITHUB_API_TOKEN }}
branch: spdx-update branch: spdx-update
force: true
- name: Open a pull request - name: Open a pull request
if: steps.update.outputs.committed == 'true' if: steps.update.outputs.committed == 'true'
run: | run: hub pull-request --no-edit
cd "$GITHUB_WORKSPACE/Library/Homebrew"
hub pull-request --no-edit
env: env:
GITHUB_TOKEN: ${{ secrets.HOMEBREW_GITHUB_API_TOKEN }} GITHUB_TOKEN: ${{ secrets.HOMEBREW_GITHUB_API_TOKEN }}
...@@ -33,22 +33,20 @@ jobs: ...@@ -33,22 +33,20 @@ jobs:
- name: Update Tapioca definitions - name: Update Tapioca definitions
id: update id: update
run: | run: |
cd "$GITHUB_WORKSPACE/Library/Homebrew"
git fetch origin master git fetch origin master
git reset --hard origin/master git reset origin/master
git checkout -B tapioca-update git checkout -B tapioca-update
# TODO: replace with `brew typecheck` # TODO: replace with `brew typecheck`
cd "$GITHUB_WORKSPACE/Library/Homebrew"
bundle exec tapioca sync --exclude json bundle exec tapioca sync --exclude json
bundle exec srb rbi hidden-definitions bundle exec srb rbi hidden-definitions
if ! git diff --no-patch --exit-code -- sorbet; then if ! git diff --no-patch --exit-code -- sorbet; then
if ! git ls-remote --exit-code --heads origin tapioca-update >/dev/null; then
git add sorbet # if brew typecheck --update --fail-if-not-changed; then
git commit -m "sorbet: update RBI files using Tapioca." -m "Autogenerated by [a scheduled GitHub Action](https://github.com/Homebrew/brew/blob/master/.github/workflows/tapioca.yml)." git add "$GITHUB_WORKSPACE/Library/Homebrew/sorbet"
echo "::set-output name=committed::true" git commit -m "sorbet: update RBI files using Tapioca." -m "Autogenerated by [a scheduled GitHub Action](https://github.com/Homebrew/brew/blob/master/.github/workflows/tapioca.yml)."
fi echo "::set-output name=committed::true"
fi fi
- name: Push commits - name: Push commits
...@@ -57,6 +55,7 @@ jobs: ...@@ -57,6 +55,7 @@ jobs:
with: with:
token: ${{ secrets.HOMEBREW_GITHUB_API_TOKEN }} token: ${{ secrets.HOMEBREW_GITHUB_API_TOKEN }}
branch: tapioca-update branch: tapioca-update
force: true
- name: Open a pull request - name: Open a pull request
if: steps.update.outputs.committed == 'true' if: steps.update.outputs.committed == 'true'
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment