Skip to content
Snippets Groups Projects
Commit be0a1e76 authored by Jack Nagel's avatar Jack Nagel
Browse files

Check empty? to avoid introducing nils

[].last => nil
[].max => nil
parent 13540f85
No related branches found
No related tags found
No related merge requests found
......@@ -125,14 +125,17 @@ module Homebrew
return ofail "Formula has no stable version: #{f.name}"
end
if ARGV.include? '--no-revision'
bottle_revision = 0
else
bottle_revision = 0
unless ARGV.include? "--no-revision"
ohai "Determining #{f.name} bottle revision..."
versions = FormulaVersions.new(f)
bottle_revisions = versions.bottle_version_map("origin/master")[f.pkg_version]
bottle_revisions.pop if bottle_revisions.last.to_i > 0
bottle_revision = bottle_revisions.any? ? bottle_revisions.max.to_i + 1 : 0
unless bottle_revisions.empty?
bottle_revisions.pop if bottle_revisions.last > 0
bottle_revision = bottle_revisions.max + 1
end
end
filename = Bottle::Filename.create(f, bottle_tag, bottle_revision)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment