Skip to content
Snippets Groups Projects
Unverified Commit b75733f1 authored by Mike McQuaid's avatar Mike McQuaid
Browse files

rubocops: downgrade strict cops (passing in core).

parent 56c02485
No related branches found
No related tags found
No related merge requests found
......@@ -70,7 +70,7 @@ module RuboCop
end
end
module FormulaAuditStrict
module FormulaAudit
# - `test do ..end` should be meaningfully defined in the formula.
class Test < FormulaCop
def audit_formula(_node, _class_node, _parent_class_node, body_node)
......
......@@ -38,7 +38,7 @@ module RuboCop
end
end
module FormulaAuditStrict
module FormulaAudit
# This cop audits `desc` in Formulae.
#
# - Checks for leading/trailing whitespace in `desc`
......
......@@ -61,16 +61,18 @@ module RuboCop
find_method_with_args(body_node, :system, "cargo", "build") do
problem "use \"cargo\", \"install\", \"--root\", prefix, \"--path\", \".\""
end
find_method_with_args(body_node, :go_resource) do
problem "`go_resource`s are deprecated. Please ask upstream to implement Go vendoring"
end
end
end
end
# Keep this (empty) module and class around in case we need it later to
# avoid deleting all the FormulaAuditStrict referencing logic.
module FormulaAuditStrict
class Text < FormulaCop
def audit_formula(_node, _class_node, _parent_class_node, body_node)
find_method_with_args(body_node, :go_resource) do
problem "`go_resource`s are deprecated. Please ask upstream to implement Go vendoring"
end
end
end
end
end
......
......@@ -105,7 +105,7 @@ describe RuboCop::Cop::FormulaAudit::TestCalls do
end
end
describe RuboCop::Cop::FormulaAuditStrict::Test do
describe RuboCop::Cop::FormulaAudit::Test do
subject(:cop) { described_class.new }
it "reports an offense when there is no test block" do
......
......@@ -48,7 +48,7 @@ describe RuboCop::Cop::FormulaAudit::DescLength do
end
end
describe RuboCop::Cop::FormulaAuditStrict::Desc do
describe RuboCop::Cop::FormulaAudit::Desc do
subject(:cop) { described_class.new }
context "When auditing formula desc" do
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment