-
- Downloads
Audit correct `uses_from_macos` usage with RuboCop
- This builds on @jonchang's work that started in #6265. - We now use `uses_from_macos` to declare dependencies that are implicit on macOS because they ship with macOS, but they're needed on Linux. We have to be sure that the dependencies people specify as `uses_from_macos` are actually shipped with macOS. So, we maintain a safelist of those dependencies and check against it. - Also add more legitimate `uses_from_macos` dependencies to the list. - This is runnable with `brew audit --only-cops=FormulaAudit/UsesFromMacos`. - It produces different number of failures on macOS vs. Linux, because apparently we've not synced Homebrew/linuxbrew-core upstream thoroughly enough yet. - Originally this was designed as a `--strict` audit, but we flipped it to be a normal audit because - to quote Mike - this is "sufficiently robust" now.
Showing
- Library/Homebrew/rubocops.rb 1 addition, 0 deletionsLibrary/Homebrew/rubocops.rb
- Library/Homebrew/rubocops/uses_from_macos.rb 52 additions, 0 deletionsLibrary/Homebrew/rubocops/uses_from_macos.rb
- Library/Homebrew/test/.rubocop_todo.yml 1 addition, 0 deletionsLibrary/Homebrew/test/.rubocop_todo.yml
- Library/Homebrew/test/rubocops/uses_from_macos_spec.rb 19 additions, 0 deletionsLibrary/Homebrew/test/rubocops/uses_from_macos_spec.rb
Loading
Please register or sign in to comment