Skip to content
Snippets Groups Projects
Unverified Commit 84930afb authored by Jonathan Chang's avatar Jonathan Chang Committed by GitHub
Browse files

Merge pull request #8906 from jonchang/tweak-signoff

pr-pull: clean up review signoff trailer code
parents e9987cd3 e7b65c62
No related branches found
No related tags found
Loading
......@@ -104,9 +104,10 @@ module Homebrew
if pr
# This is a tap pull request and approving reviewers should also sign-off.
tap = Tap.from_path(path)
trailers += GitHub.approved_reviews(tap.user, tap.full_name.split("/").last, pr).map do |r|
review_trailers = GitHub.approved_reviews(tap.user, tap.full_name.split("/").last, pr).map do |r|
"Signed-off-by: #{r["name"]} <#{r["email"]}>"
end.join("\n")
end
trailers = trailers.lines.concat(review_trailers).map(&:strip).uniq.join("\n")
# Append the close message as well, unless the commit body already includes it.
close_message = "Closes ##{pr}."
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment