Skip to content
Snippets Groups Projects
Commit 79280826 authored by ilovezfs's avatar ilovezfs
Browse files

pull: fix false positives for nonstandard bump subjects when untapped

If the formula's tap isn't tapped yet when running `brew pull`, a false
positive occurs for the nonstandard bump subject check, and a bogus
warning is printed, which claims the bump subject should refer to the
old version not the new version.
parent bef2c6c9
No related branches found
No related tags found
No related merge requests found
......@@ -376,7 +376,7 @@ module Homebrew
subject_strs << "remove stable"
formula_name_str += ":" # just for cosmetics
else
subject_strs << formula.version.to_s
subject_strs << new[:stable]
end
end
if old[:devel] != new[:devel]
......@@ -387,7 +387,7 @@ module Homebrew
formula_name_str += ":" # just for cosmetics
end
else
subject_strs << "#{formula.devel.version} (devel)"
subject_strs << "#{new[:devel]} (devel)"
end
end
subject = subject_strs.empty? ? nil : "#{formula_name_str} #{subject_strs.join(", ")}"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment