Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
B
brew
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to JiHu GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
KMSCAKKSCFKA AKFACAMADCAS
brew
Commits
6e7731ae
Commit
6e7731ae
authored
15 years ago
by
Adam Vandenberg
Browse files
Options
Downloads
Patches
Plain Diff
Add test for legacy prefix quoting.
parent
47a38f49
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
Library/Homebrew/test/formula_test.rb
+13
-2
13 additions, 2 deletions
Library/Homebrew/test/formula_test.rb
with
13 additions
and
2 deletions
Library/Homebrew/test/formula_test.rb
+
13
−
2
View file @
6e7731ae
...
...
@@ -39,11 +39,22 @@ class FormulaNames <Test::Unit::TestCase
end
end
class
CommentedTemplateCode
<
Test
::
Unit
::
TestCase
class
WellKnownCodeIssues
<
Test
::
Unit
::
TestCase
def
test_for_commented_out_cmake
Dir
[
"
#{
HOMEBREW_PREFIX
}
/Library/Formula/*.rb"
].
each
do
|
f
|
result
=
`grep "# depends_on 'cmake'" "
#{
f
}
"`
.
strip
assert_equal
(
''
,
result
,
"Commented template code still in
#{
f
}
"
)
end
end
end
\ No newline at end of file
def
test_for_misquoted_prefix
# Prefix should not have single quotes if the system args are already separated
target_string
=
"[
\\\"
]--prefix=[
\\
']"
Dir
[
"
#{
HOMEBREW_PREFIX
}
/Library/Formula/*.rb"
].
each
do
|
f
|
result
=
`grep -e "
#{
target_string
}
" "
#{
f
}
"`
.
strip
assert_equal
(
''
,
result
,
"--prefix is incorrectly single-quoted in
#{
f
}
"
)
end
end
end
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment