Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
B
brew
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to JiHu GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
KMSCAKKSCFKA AKFACAMADCAS
brew
Commits
629ad219
Commit
629ad219
authored
4 years ago
by
Rylan Polster
Browse files
Options
Downloads
Patches
Plain Diff
Migrate MAKE_CHECK_ALLOWLIST
parent
e823dd71
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
Library/Homebrew/rubocops/lines.rb
+1
-21
1 addition, 21 deletions
Library/Homebrew/rubocops/lines.rb
Library/Homebrew/test/rubocops/lines_spec.rb
+0
-2
0 additions, 2 deletions
Library/Homebrew/test/rubocops/lines_spec.rb
with
1 addition
and
23 deletions
Library/Homebrew/rubocops/lines.rb
+
1
−
21
View file @
629ad219
...
...
@@ -623,33 +623,13 @@ module RuboCop
#
# @api private
class
MakeCheck
<
FormulaCop
MAKE_CHECK_ALLOWLIST
=
%w[
beecrypt
ccrypt
git
gmp
gnupg
gnupg@1.4
google-sparsehash
jemalloc
jpeg-turbo
mpfr
nettle
open-mpi
openssl@1.1
pcre
protobuf
wolfssl
xz
]
.
freeze
def
audit_formula
(
_node
,
_class_node
,
_parent_class_node
,
body_node
)
return
if
formula_tap
!=
"homebrew-core"
# Avoid build-time checks in homebrew/core
find_every_method_call_by_name
(
body_node
,
:system
).
each
do
|
method
|
next
if
@formula_name
.
start_with?
(
"lib"
)
next
if
MAKE_CHECK_ALLOWLIST
.
include?
(
@formula_name
)
next
if
tap_style_exception?
:make_check_allowlist
params
=
parameters
(
method
)
next
unless
node_equals?
(
params
[
0
],
"make"
)
...
...
This diff is collapsed.
Click to expand it.
Library/Homebrew/test/rubocops/lines_spec.rb
+
0
−
2
View file @
629ad219
...
...
@@ -1479,8 +1479,6 @@ describe RuboCop::Cop::FormulaAuditStrict::MakeCheck do
end
RUBY
end
include_examples
"formulae exist"
,
described_class
::
MAKE_CHECK_ALLOWLIST
end
describe
RuboCop
::
Cop
::
FormulaAuditStrict
::
ShellCommands
do
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment