Merge pull request #5181 from reitermarkus/upgrade-login-items

cask: Don’t remove login items on upgrade.

Library/Homebrew/cask/artifact/abstract_uninstall.rb

@@ -169,7 +169,9 @@ module Cask
         end
       end
 
-      def uninstall_login_item(*login_items, command: nil, **_)
+      def uninstall_login_item(*login_items, command: nil, upgrade: false, **_)
+        return if upgrade
+
         login_items.each do |name|
           ohai "Removing login item #{name}"
           command.run!(

Library/Homebrew/cask/installer.rb

@@ -424,7 +424,7 @@ module Cask
         next unless artifact.respond_to?(:uninstall_phase)
 
         odebug "Un-installing artifact of class #{artifact.class}"
-        artifact.uninstall_phase(command: @command, verbose: verbose?, skip: clear, force: force?)
+        artifact.uninstall_phase(command: @command, verbose: verbose?, skip: clear, force: force?, upgrade: upgrade?)
       end
     end