Skip to content
Snippets Groups Projects
Commit 3b153820 authored by Mike McQuaid's avatar Mike McQuaid
Browse files

audit: git tags should also specify revisions.

parent b6a0105b
No related branches found
No related tags found
No related merge requests found
......@@ -872,6 +872,14 @@ class ResourceAuditor
problem "Use of the #{$&} scheme is deprecated, pass `:using => :#{$1}` instead"
end
url_strategy = DownloadStrategyDetector.detect(url)
if using == :git || url_strategy == GitDownloadStrategy
if specs[:tag] && !specs[:revision]
problem "Git should specify :revision when a :tag is specified."
end
end
return unless using
if using == :ssl3 || using == CurlSSL3DownloadStrategy
......@@ -898,7 +906,6 @@ class ResourceAuditor
end
end
url_strategy = DownloadStrategyDetector.detect(url)
using_strategy = DownloadStrategyDetector.detect('', using)
if url_strategy == using_strategy
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment