Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
B
brew
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to JiHu GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
KMSCAKKSCFKA AKFACAMADCAS
brew
Commits
2b029b27
Commit
2b029b27
authored
4 years ago
by
Markus Reiter
Browse files
Options
Downloads
Patches
Plain Diff
Remove need for separate `.rubocop_cask.yml`.
parent
fecc701a
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
Library/.rubocop.yml
+26
-2
26 additions, 2 deletions
Library/.rubocop.yml
Library/.rubocop_cask.yml
+3
-34
3 additions, 34 deletions
Library/.rubocop_cask.yml
Library/Homebrew/cask/cmd/style.rb
+1
-1
1 addition, 1 deletion
Library/Homebrew/cask/cmd/style.rb
with
30 additions
and
37 deletions
Library/.rubocop.yml
+
26
−
2
View file @
2b029b27
...
...
@@ -8,6 +8,30 @@ AllCops:
# enable all pending rubocops
NewCops
:
enable
Cask/Desc
:
Description
:
'
Ensure
that
the
desc
stanza
conforms
to
various
content
and
style
checks.'
Enabled
:
true
Cask/HomepageMatchesUrl
:
Description
:
'
Ensure
that
the
homepage
and
url
match,
otherwise
add
a
comment.
More
info
at
https://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/cask_language_reference/stanzas/url.md#when-url-and-homepage-hostnames-differ-add-a-comment'
Enabled
:
true
Cask/HomepageUrlTrailingSlash
:
Description
:
'
Ensure
that
the
homepage
url
has
a
slash
after
the
domain
name.'
Enabled
:
true
Cask/NoDslVersion
:
Description
:
'
Do
not
use
the
deprecated
DSL
version
syntax
in
your
cask
header.'
Enabled
:
true
Cask/StanzaGrouping
:
Description
:
'
Ensure
that
cask
stanzas
are
grouped
correctly.
More
info
at
https://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/cask_language_reference/readme.md#stanza-order'
Enabled
:
true
Cask/StanzaOrder
:
Description
:
'
Ensure
that
cask
stanzas
are
sorted
correctly.
More
info
at
https://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/cask_language_reference/readme.md#stanza-order'
Enabled
:
true
# enable all formulae audits
FormulaAudit
:
Enabled
:
true
...
...
@@ -195,11 +219,11 @@ Style/ClassVars:
Exclude
:
-
'
**/developer/bin/*'
#
most of our APIs are internal so don't require docs
#
Don't enforce documentation in casks or formulae.
Style/Documentation
:
Enabled
:
false
#
don't want this for formulae but re-enabled for Library/Homebrew
#
Not used for casks and formulae.
Style/FrozenStringLiteralComment
:
Enabled
:
false
...
...
This diff is collapsed.
Click to expand it.
Library/.rubocop_cask.yml
+
3
−
34
View file @
2b029b27
inherit_from
:
./Homebrew/.rubocop.yml
Cask/Desc
:
Description
:
'
Ensure
that
the
desc
stanza
conforms
to
various
content
and
style
checks.'
Enabled
:
true
Cask/HomepageMatchesUrl
:
Description
:
'
Ensure
that
the
homepage
and
url
match,
otherwise
add
a
comment.
More
info
at
https://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/cask_language_reference/stanzas/url.md#when-url-and-homepage-hostnames-differ-add-a-comment'
Enabled
:
true
Cask/HomepageUrlTrailingSlash
:
Description
:
'
Ensure
that
the
homepage
url
has
a
slash
after
the
domain
name.'
Enabled
:
true
Cask/NoDslVersion
:
Description
:
'
Do
not
use
the
deprecated
DSL
version
syntax
in
your
cask
header.'
Enabled
:
true
# TODO: This file can be deleted once https://github.com/Homebrew/brew/pull/8542
# is in a stable release and `rubocop.yml` has been removed from all cask taps.
Cask/StanzaGrouping
:
Description
:
'
Ensure
that
cask
stanzas
are
grouped
correctly.
More
info
at
https://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/cask_language_reference/readme.md#stanza-order'
Enabled
:
true
Cask/StanzaOrder
:
Description
:
'
Ensure
that
cask
stanzas
are
sorted
correctly.
More
info
at
https://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/cask_language_reference/readme.md#stanza-order'
Enabled
:
true
# don't want these for casks but re-enabled for Library/Homebrew
Style/FrozenStringLiteralComment
:
Enabled
:
false
Style/Documentation
:
Enabled
:
false
Metrics/BlockLength
:
Enabled
:
false
inherit_from
:
./Homebrew/.rubocop.yml
This diff is collapsed.
Click to expand it.
Library/Homebrew/cask/cmd/style.rb
+
1
−
1
View file @
2b029b27
...
...
@@ -27,7 +27,7 @@ module Cask
args
=
[
"--force-exclusion"
,
"--config"
,
"
#{
HOMEBREW_LIBRARY
}
/.rubocop
_cask
.yml"
"--config"
,
HOMEBREW_LIBRARY
/
"
.rubocop.yml"
]
if
json
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment