Skip to content
Snippets Groups Projects
Commit 2635817c authored by Chris Kampmeier's avatar Chris Kampmeier Committed by Mike McQuaid
Browse files

doctor: don't let gitconfig break dirty-tree check


`brew doctor` always complains about uncommitted modifications to
Homebrew when you have status.branch=true in your git config, because
the implicit --branch makes `git status -s` always print branch/tracking
info. The --porcelain mode is similar to -s/--short, but ignores most of
the user's config and should remain stable.

The --untracked-files option ensures we'll see untracked files even for
users with status.showUntrackedFiles=no, which is not suppressed by
--porcelain for some reason.

Closes Homebrew/homebrew#25230.

Signed-off-by: default avatarMike McQuaid <mike@mikemcquaid.com>
parent d1d6451a
No related branches found
No related tags found
No related merge requests found
......@@ -909,7 +909,7 @@ end
def check_git_status
return unless which "git"
HOMEBREW_REPOSITORY.cd do
unless `git status -s -- Library/Homebrew/ 2>/dev/null`.chomp.empty?
unless `git status --untracked-files=all --porcelain -- Library/Homebrew/ 2>/dev/null`.chomp.empty?
<<-EOS.undent_________________________________________________________72
You have uncommitted modifications to Homebrew
If this a surprise to you, then you should stash these modifications.
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment