Skip to content
Snippets Groups Projects
Unverified Commit 24f5e695 authored by Mike McQuaid's avatar Mike McQuaid Committed by GitHub
Browse files

Merge pull request #6133 from zbeekman/exception-for-veclibfort-accelerate-audit

Add exception for veclibfort linking to Accelerate
parents 191898ce 056a2d41
No related branches found
No related tags found
No related merge requests found
......@@ -15,9 +15,9 @@ module Homebrew
present, "revision 1" will be added.
EOS
switch "-n", "--dry-run",
description: "Print what would be done rather than doing it."
description: "Print what would be done rather than doing it."
flag "--message=",
description: "Append the provided <message> to the default commit message."
description: "Append the provided <message> to the default commit message."
switch :force
switch :quiet
......@@ -76,7 +76,7 @@ module Homebrew
else
formula.path.parent.cd do
safe_system "git", "commit", "--no-edit", "--verbose",
"--message=#{message}", "--", formula.path
"--message=#{message}", "--", formula.path
end
end
end
......
......@@ -51,6 +51,7 @@ module FormulaCellarChecks
def check_accelerate_framework_links
return unless @core_tap
return unless formula.prefix.directory?
return if formula.name == "veclibfort" # veclibfort exists to wrap accelerate
keg = Keg.new(formula.prefix)
system_accelerate = keg.mach_o_files.select do |obj|
......@@ -63,7 +64,8 @@ module FormulaCellarChecks
object files were linked against system Accelerate
These object files were linked against the outdated system Accelerate framework.
Core tap formulae should link against OpenBLAS instead.
Adding `depends_on "openblas"` to the formula may help.
Removing `depends_on "veclibfort" and/or adding `depends_on "openblas"` to the
formula may help.
#{system_accelerate * "\n "}
EOS
end
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment