Merge pull request #8727 from dawidd6/pr-pull-gh-rel

pr-pull: don't require bintray credentials to be set

Library/Homebrew/dev-cmd/pr-pull.rb

@@ -4,7 +4,6 @@ require "download_strategy"
 require "cli/parser"
 require "utils/github"
 require "tmpdir"
-require "bintray"
 require "formula"
 
 module Homebrew
@@ -24,7 +23,7 @@ module Homebrew
                           "upload the bottles to Bintray, but don't publish them."
       switch "--no-upload",
              description: "Download the bottles and apply the bottle commit, "\
-                          "but don't upload to Bintray."
+                          "but don't upload to Bintray or GitHub Releases."
       switch "-n", "--dry-run",
              description: "Print what would be done rather than doing it."
       switch "--clean",
@@ -211,16 +210,9 @@ module Homebrew
   def pr_pull
     args = pr_pull_args.parse
 
-    bintray_user = ENV["HOMEBREW_BINTRAY_USER"]
-    bintray_key = ENV["HOMEBREW_BINTRAY_KEY"]
-    bintray_org = args.bintray_org || "homebrew"
-
-    if (bintray_user.blank? || bintray_key.blank?) && !args.dry_run? && !args.no_upload?
-      odie "Missing HOMEBREW_BINTRAY_USER or HOMEBREW_BINTRAY_KEY variables!"
-    end
-
     workflow = args.workflow || "tests.yml"
     artifact = args.artifact || "bottles"
+    bintray_org = args.bintray_org || "homebrew"
     mirror_repo = args.bintray_mirror || "mirror"
     tap = Tap.fetch(args.tap || CoreTap.instance.name)
 

docs/Manpage.md

@@ -1085,7 +1085,7 @@ Requires write access to the repository.
 * `--no-publish`:
   Download the bottles, apply the bottle commit and upload the bottles to Bintray, but don't publish them.
 * `--no-upload`:
-  Download the bottles and apply the bottle commit, but don't upload to Bintray.
+  Download the bottles and apply the bottle commit, but don't upload to Bintray or GitHub Releases.
 * `-n`, `--dry-run`:
   Print what would be done rather than doing it.
 * `--clean`:

manpages/brew.1

@@ -1496,7 +1496,7 @@ Download the bottles, apply the bottle commit and upload the bottles to Bintray,
 .
 .TP
 \fB\-\-no\-upload\fR
-Download the bottles and apply the bottle commit, but don\'t upload to Bintray\.
+Download the bottles and apply the bottle commit, but don\'t upload to Bintray or GitHub Releases\.
 .
 .TP
 \fB\-n\fR, \fB\-\-dry\-run\fR