Skip to content
Snippets Groups Projects
Commit 0f2c5f33 authored by Jack Nagel's avatar Jack Nagel
Browse files

Add an exception for imagemagick in build-time dep audit

parent db380538
No related branches found
No related tags found
No related merge requests found
......@@ -145,10 +145,14 @@ class FormulaAuditor
case dep.name
when *BUILD_TIME_DEPS
# Build deps should be tagged
problem <<-EOS.undent unless dep.tags.any? || f.name =~ /automake/ && dep.name == 'autoconf'
#{dep} dependency should be "depends_on '#{dep}' => :build"
EOS
# TODO: this should really be only dep.build? but maybe some formula
# depends on the current behavior to be audit-clean?
next if dep.tags.any?
next if f.name =~ /automake/ && dep.name == 'autoconf'
# This is actually a libltdl dep that gets converted to a non-build time
# libtool dep, but I don't of a good way to encode this in the dep object
next if f.name == 'imagemagick' && dep.name == 'libtool'
problem %{#{dep} dependency should be "depends_on '#{dep}' => :build"}
when "git", "ruby", "emacs", "mercurial"
problem <<-EOS.undent
Don't use #{dep} as a dependency. We allow non-Homebrew
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment