Skip to content
Snippets Groups Projects
Unverified Commit 068568e6 authored by Dustin Rodrigues's avatar Dustin Rodrigues Committed by GitHub
Browse files

Merge pull request #8218 from dtrodrigues/homepage-style-wording

style: clarify GitHub .git error message
parents e76cea16 5157c083
No related branches found
No related tags found
No related merge requests found
......@@ -64,7 +64,7 @@ module RuboCop
when %r{^https://github.com.*\.git}
offending_node(parameters(homepage_node).first)
problem "GitHub URLs (`#{homepage}`) should not end with .git"
problem "GitHub homepages (`#{homepage}`) should not end with .git"
# There's an auto-redirect here, but this mistake is incredibly common too.
# Only applies to the homepage and subdomains for now, not the FTP URLs.
......
......@@ -104,7 +104,7 @@ describe RuboCop::Cop::FormulaAudit::Homepage do
column: 2,
source: source }]
elsif homepage.match?("https://github.com/foo/bar.git")
expected_offenses = [{ message: "GitHub URLs (`#{homepage}`) should not end with .git",
expected_offenses = [{ message: "GitHub homepages (`#{homepage}`) should not end with .git",
severity: :convention,
line: 2,
column: 11,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment