Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
B
brew
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to JiHu GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
KMSCAKKSCFKA AKFACAMADCAS
brew
Commits
03253a8d
Commit
03253a8d
authored
8 years ago
by
Viktor Szakats
Browse files
Options
Downloads
Patches
Plain Diff
audit: enforce
https://*.sourceforge.io/
homepages
Ref:
https://sourceforge.net/blog/introducing-https-for-project-websites/
parent
8535a8cd
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
Library/Homebrew/dev-cmd/audit.rb
+4
-0
4 additions, 0 deletions
Library/Homebrew/dev-cmd/audit.rb
Library/Homebrew/test/audit_test.rb
+5
-0
5 additions, 0 deletions
Library/Homebrew/test/audit_test.rb
with
9 additions
and
0 deletions
Library/Homebrew/dev-cmd/audit.rb
+
4
−
0
View file @
03253a8d
...
...
@@ -584,6 +584,10 @@ class FormulaAuditor
problem
"Please use https:// for
#{
homepage
}
"
end
if
homepage
=~
%r{^http://([^/]*)
\.
(sf|sourceforge)
\.
net(/|$)}
problem
"
#{
homepage
}
should be `https://
#{
$1
}
.sourceforge.io/`"
end
# There's an auto-redirect here, but this mistake is incredibly common too.
# Only applies to the homepage and subdomains for now, not the FTP URLs.
if
homepage
=~
%r{^http://((?:build|cloud|developer|download|extensions|git|glade|help|library|live|nagios|news|people|projects|rt|static|wiki|www)
\.
)?gnome
\.
org}
...
...
This diff is collapsed.
Click to expand it.
Library/Homebrew/test/audit_test.rb
+
5
−
0
View file @
03253a8d
...
...
@@ -431,6 +431,9 @@ class FormulaAuditorTests < Homebrew::TestCase
"corge"
=>
"http://savannah.nongnu.org/corge"
,
"grault"
=>
"http://grault.github.io/"
,
"garply"
=>
"http://www.gnome.org/garply"
,
"sf1"
=>
"http://foo.sourceforge.net/"
,
"sf2"
=>
"http://foo.sourceforge.net"
,
"sf3"
=>
"http://foo.sf.net/"
,
"waldo"
=>
"http://www.gnu.org/waldo"
,
}
...
...
@@ -455,6 +458,8 @@ class FormulaAuditorTests < Homebrew::TestCase
end
elsif
homepage
=~
%r{https:
\/\/
code
\.
google
\.
com}
assert_match
"
#{
homepage
}
should end with a slash"
,
fa
.
problems
.
first
elsif
homepage
=~
/foo\.(sf|sourceforge)\.net/
assert_match
"
#{
homepage
}
should be `https://foo.sourceforge.io/`"
,
fa
.
problems
.
first
else
assert_match
"Please use https:// for
#{
homepage
}
"
,
fa
.
problems
.
first
end
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment