Skip to content
Snippets Groups Projects
Commit ddab795b authored by Paul Spooren's avatar Paul Spooren
Browse files

rules: fix empty COMMITCOUNT/AUTORELEASE


Packages that are in-tree only often lack a PKG_VERSION and only use the
PKG_RELEASE to mark changes. Using COMMITCOUNT/AUTORELEASE variables
causes an issue as both variables are empty during the metadata DUMP
phase.

Instead of leaving these variables empty and causing an error message
like below, set the variables to 0 during dumping. On actual building
the variable is evaluated causing in a value above 0.

ERROR: please fix package/utils/px5g-wolfssl/Makefile - \
	see logs/package/utils/px5g-wolfssl/dump.txt for details

Makefile:48: *** Package/px5g-wolfssl is missing the VERSION field.  Stop.

Reported-by: default avatarDaniel Golle <daniel@makrotopia.org>
Reported-by: default avatarStijn Segers <foss@volatilesystems.org>
Reported-by: default avatarStijn Tintel <stijn@linux-ipv6.be>
Signed-off-by: default avatarPaul Spooren <mail@aparcar.org>
parent 1b484f1a
No related branches found
No related tags found
No related merge requests found
......@@ -431,8 +431,8 @@ $(shell \
)
endef
COMMITCOUNT = $(if $(DUMP),,$(call commitcount))
AUTORELEASE = $(if $(DUMP),,$(call commitcount,1))
COMMITCOUNT = $(if $(DUMP),0,$(call commitcount))
AUTORELEASE = $(if $(DUMP),0,$(call commitcount,1))
all:
FORCE: ;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment