-
- Downloads
Revert "[VFS] RedirectingFileSystem only replace path if not already mapped"
This reverts commit 3fda0edc, which breaks crash reproducers in very specific circumstances. Specifically, since crash reproducers have `UseExternalNames` set to false, the `File->getFileEntry().getDir()->getName()` call in `DoFrameworkLookup` would use the *cached* directory name instead of the directory of the looked-up file. The plan is to re-commit this patch but to *add* `ExposesExternalVFSPath` rather than replace `IsVFSMapped`. Differential Revision: https://reviews.llvm.org/D123103
Showing
- clang/lib/Basic/FileManager.cpp 12 additions, 20 deletionsclang/lib/Basic/FileManager.cpp
- clang/test/VFS/external-names-multi-overlay.c 0 additions, 39 deletionsclang/test/VFS/external-names-multi-overlay.c
- llvm/include/llvm/Support/VirtualFileSystem.h 2 additions, 13 deletionsllvm/include/llvm/Support/VirtualFileSystem.h
- llvm/lib/Support/VirtualFileSystem.cpp 2 additions, 10 deletionsllvm/lib/Support/VirtualFileSystem.cpp
- llvm/unittests/Support/VirtualFileSystemTest.cpp 22 additions, 22 deletionsllvm/unittests/Support/VirtualFileSystemTest.cpp
Loading
Please register or sign in to comment