[C++20][Modules] Adjust handling of exports of namespaces and using-decls.
This adjusts the handling for: export module M; export namespace {}; export namespace N {}; export using namespace N; In the first case, we were allowing empty anonymous namespaces as part of an extension allowing empty top-level entities, but that seems inappropriate in this case, since the linkage would be internal for the anonymous namespace. We now report an error for this. The second case was producing a warning diagnostic that this was accepted as an extension - however the C++20 standard does allow this as well-formed. In the third case we keep the current practice that this is accepted with a warning (as an extension). The C++20 standard says it's an error. We also ensure that using decls are only applied to items with external linkage. This adjusts error messages for exports involving redeclarations in modules to be more specific about the reason that the decl has been rejected. Differential Revision: https://reviews.llvm.org/D122119
Showing
- clang/include/clang/Basic/DiagnosticSemaKinds.td 6 additions, 3 deletionsclang/include/clang/Basic/DiagnosticSemaKinds.td
- clang/lib/Sema/SemaDecl.cpp 7 additions, 1 deletionclang/lib/Sema/SemaDecl.cpp
- clang/lib/Sema/SemaModule.cpp 23 additions, 6 deletionsclang/lib/Sema/SemaModule.cpp
- clang/test/CXX/module/module.interface/p3.cpp 5 additions, 5 deletionsclang/test/CXX/module/module.interface/p3.cpp
- clang/test/CXX/module/module.interface/p5.cpp 19 additions, 19 deletionsclang/test/CXX/module/module.interface/p5.cpp
- clang/test/CXX/module/module.interface/p6.cpp 15 additions, 15 deletionsclang/test/CXX/module/module.interface/p6.cpp
- clang/test/Modules/cxx20-10-2-ex1.cpp 31 additions, 0 deletionsclang/test/Modules/cxx20-10-2-ex1.cpp
- clang/test/Modules/cxx20-10-2-ex3.cpp 9 additions, 0 deletionsclang/test/Modules/cxx20-10-2-ex3.cpp
- clang/test/Modules/cxx20-10-2-ex4.cpp 12 additions, 0 deletionsclang/test/Modules/cxx20-10-2-ex4.cpp
- clang/test/Modules/cxx20-10-2-ex5.cpp 54 additions, 0 deletionsclang/test/Modules/cxx20-10-2-ex5.cpp
- clang/test/Modules/cxx20-10-2-ex6.cpp 21 additions, 0 deletionsclang/test/Modules/cxx20-10-2-ex6.cpp
- clang/test/Modules/cxx20-10-2-ex7.cpp 9 additions, 0 deletionsclang/test/Modules/cxx20-10-2-ex7.cpp
Loading
Please register or sign in to comment