Remove a few effectively-unused FileEntry APIs. NFC
- isValid: FileManager only ever returns valid FileEntries (see next point) - construction from outside FileManager (both FileEntry and DirectoryEntry). It's not possible to create a useful FileEntry this way, there are no setters. This was only used in FileEntryTest, added a friend to enable this. A real constructor is cleaner but requires larger changes to FileManager. Differential Revision: https://reviews.llvm.org/D123197
Showing
- clang/include/clang/Basic/DirectoryEntry.h 4 additions, 0 deletionsclang/include/clang/Basic/DirectoryEntry.h
- clang/include/clang/Basic/FileEntry.h 4 additions, 10 deletionsclang/include/clang/Basic/FileEntry.h
- clang/lib/Basic/FileManager.cpp 0 additions, 3 deletionsclang/lib/Basic/FileManager.cpp
- clang/lib/Frontend/LogDiagnosticPrinter.cpp 2 additions, 4 deletionsclang/lib/Frontend/LogDiagnosticPrinter.cpp
- clang/lib/Frontend/TextDiagnostic.cpp 1 addition, 2 deletionsclang/lib/Frontend/TextDiagnostic.cpp
- clang/unittests/Basic/FileEntryTest.cpp 17 additions, 29 deletionsclang/unittests/Basic/FileEntryTest.cpp
- clang/unittests/Basic/FileManagerTest.cpp 0 additions, 13 deletionsclang/unittests/Basic/FileManagerTest.cpp
Loading
Please register or sign in to comment