-
- Downloads
[clangd] Cleanup of readability-identifier-naming
Auto-generated patch based on clang-tidy readability-identifier-naming. Only some manual cleanup for `extern "C"` declarations and a GTest change was required. I'm not sure if this cleanup is actually very useful. It cleans up clang-tidy findings to the number of warnings from clang-tidy should be lower. Since it was easy to do and required only little cleanup I thought I'd upload it for discussion. One pattern that keeps recurring: Test **matchers** are also supposed to start with a lowercase letter as per LLVM convention. However GTest naming convention for matchers start with upper case. I would propose to keep stay consistent with the GTest convention there. However that would imply a lot of `//NOLINT` throughout these files. To re-product this patch run: ``` run-clang-tidy -checks="-*,readability-identifier-naming" -fix -format ./clang-tools-extra/clangd ``` To convert the macro names, I was using this script with some manual cleanup afterwards: https://gist.github.com/ChristianKuehnel/a01cc4362b07c58281554ab46235a077 Differential Revision: https://reviews.llvm.org/D115634
Showing
- .clang-tidy 4 additions, 0 deletions.clang-tidy
- clang-tools-extra/clangd/ClangdLSPServer.cpp 6 additions, 6 deletionsclang-tools-extra/clangd/ClangdLSPServer.cpp
- clang-tools-extra/clangd/SourceCode.cpp 2 additions, 2 deletionsclang-tools-extra/clangd/SourceCode.cpp
- clang-tools-extra/clangd/TUScheduler.cpp 4 additions, 4 deletionsclang-tools-extra/clangd/TUScheduler.cpp
- clang-tools-extra/clangd/XRefs.cpp 3 additions, 1 deletionclang-tools-extra/clangd/XRefs.cpp
- clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp 6 additions, 6 deletionsclang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
- clang-tools-extra/clangd/fuzzer/clangd-fuzzer.cpp 3 additions, 3 deletionsclang-tools-extra/clangd/fuzzer/clangd-fuzzer.cpp
- clang-tools-extra/clangd/index/YAMLSerialization.cpp 6 additions, 6 deletionsclang-tools-extra/clangd/index/YAMLSerialization.cpp
- clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp 50 additions, 51 deletionsclang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp
- clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp 54 additions, 54 deletionsclang-tools-extra/clangd/unittests/CallHierarchyTests.cpp
- clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp 10 additions, 10 deletionsclang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp
- clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp 355 additions, 354 deletionsclang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
- clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp 8 additions, 8 deletionsclang-tools-extra/clangd/unittests/CompileCommandsTests.cpp
- clang-tools-extra/clangd/unittests/ConfigCompileTests.cpp 15 additions, 15 deletionsclang-tools-extra/clangd/unittests/ConfigCompileTests.cpp
- clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp 6 additions, 6 deletionsclang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
- clang-tools-extra/clangd/unittests/ConfigTesting.h 4 additions, 4 deletionsclang-tools-extra/clangd/unittests/ConfigTesting.h
- clang-tools-extra/clangd/unittests/ConfigYAMLTests.cpp 29 additions, 26 deletionsclang-tools-extra/clangd/unittests/ConfigYAMLTests.cpp
- clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp 94 additions, 94 deletionsclang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
- clang-tools-extra/clangd/unittests/DumpASTTests.cpp 3 additions, 3 deletionsclang-tools-extra/clangd/unittests/DumpASTTests.cpp
- clang-tools-extra/clangd/unittests/ExpectedTypeTest.cpp 8 additions, 8 deletionsclang-tools-extra/clangd/unittests/ExpectedTypeTest.cpp
Loading
Please register or sign in to comment