Skip to content
Snippets Groups Projects
This project is mirrored from https://git.savannah.gnu.org/git/guix/guix-cuirass.git/. Pull mirroring updated .
  1. Jun 10, 2020
    • Mathieu Othacehe's avatar
      cuirass: Use sendfiles instead of raw copies. · 2280ae18
      Mathieu Othacehe authored
      * src/cuirass/http.scm (respond-file): Send the file name as 'x-raw-file
      header argument, instead of the raw file content,
      (respond-gzipped-file): ditto. Also set 'content-disposition header.
      * src/web/server/fiberized.scm (strip-headers, with-content-length): New procedures,
      (client-loop): Check if 'x-raw-file is set. If it's the case, use sendfiles to
      send the given file. Otherwise, keep the existing behaviour and send directly
      the received bytevector.
      Unverified
      2280ae18
    • Mathieu Othacehe's avatar
      Add support for build products downloading. · f44618fc
      Mathieu Othacehe authored
      * src/sql/upgrade-7.sql: New file.
      * Makefile.am: Add it.
      * src/cuirass/base.scm (create-build-outputs): New procedure,
      (build-packages): call it,
      (process-spec): add the new spec argument and pass it to create-build-outputs.
      * src/cuirass/database.scm (db-add-build-product, db-get-build-product-path,
      db-get-build-products): New exported procedures.
      * src/cuirass/http.scm (respond-static-file): Move file sending to ...
      (respond-file): ... this new procedure,
      (url-handler): add a new "download/<id>" route, serving the requested file
      with the new respond-file procedure. Also gather build products and pass them
      to "build-details" for "build/<id>/details" route.
      * src/cuirass/templates.scm (build-details): Honor the new "products" argument
      to display all the build products associated to the given build.
      * src/schema.sql (BuildProducts): New table,
      (Specifications)[build_outputs]: new field.
      * tests/database.scm: Add empty build-outputs spec.
      * tests/http.scm: Ditto.
      * examples/guix-jobs.scm: Ditto.
      * examples/hello-git.scm: Ditto.
      * examples/hello-singleton.scm: Ditto.
      * examples/hello-subset.scm: Ditto.
      * examples/random.scm: Ditto.
      * doc/cuirass.texi (overview): Document it.
      Unverified
      f44618fc
    • Christopher Baines's avatar
      database: Begin tuning db-get-builds for performance. · 78986d96
      Christopher Baines authored
      This commit does several things, the big change is to try and construct a
      simpler query for SQLite. I'm not confident that SQLite's query planner can
      look past handling the NULL parameters, so I think it could be helpful to try
      and create a simpler query, both to avoid that problem if it exists, but also
      move the complexity in to Guile code, which I think is a bit more manageable.
      
      The way ordering is handled is also changed. Order is one of the filters,
      although it's not a filter, and some of the other filters also influenced the
      order. I think there are things still to fix/improve with the handling of
      ordering, but at least this commit just has the ordering happen once in the
      query.
      
      * src/cuirass/database.scm (filters->order): Remove procedure, inline in to
      db-get-builds.
      (db-get-builds): Change query generation in an attempt to make it easier to
      tune the queries for performance.
      78986d96
  2. May 25, 2020
    • Christopher Baines's avatar
      cuirass: Perform some database "optimization" at startup. · 9265949c
      Christopher Baines authored
      Add a "optimize" step that occurs when starting up the main Curiass
      process. Currently this does two things, but could be extended to do more.
      
      The "PRAGMA optimize;" command prompts SQLite to ANALYZE tables where that
      might help. The "PRAGMA wal_checkpoint(TRUNCATE);" command has SQLite process
      any unprocessed changes from the WAL file, then truncate it to 0 bytes. I've
      got no data to suggest this helps with performance, but I'm hoping that going
      from a large WAL file to a small one occasionally might be useful.
      
      * src/cuirass/database.scm (db-optimize): New procedure.
      * bin/cuirass.in (main): Run it.
      9265949c
    • Christopher Baines's avatar
      build-aux: Update for Guile 3. · 68a6912c
      Christopher Baines authored
      * build-aux/guix.scm (arguments): Change 2.2 to 3.0.
      (inputs): Change guile@2.2 to guile.
      68a6912c
  3. Apr 17, 2020
  4. Apr 16, 2020
  5. Feb 24, 2020
  6. Feb 06, 2020
    • Christopher Baines's avatar
      utils: Handle errors in worker threads. · bb225189
      Christopher Baines authored
      Previously, if an error occurred, the worker fiber simply never sends a
      reply. In the case of HTTP requests to Cuirass, where an exception occurs when
      performing a database query, the fiber handling the request blocks as it never
      gets a response. I think that this has the potential to cause the process to
      hit file descriptor limits, as the connections are never responded to.
      
      This is fixed by responding with the details of the exception, and then
      throwing it within the fiber that made the call.
      
      * src/cuirass/utils.scm (make-worker-thread-channel): Catch exceptions when
      calling proc.
      (call-with-worker-thread): Handle receiving exceptions from the worker thread.
      bb225189
  7. Jan 26, 2020
    • Christopher Baines's avatar
      database: Enable running up to 4 database queries at once. · b9031db9
      Christopher Baines authored
      The number of threads is copied from bin/cuirass.in. When you have at least
      two processors, this will allow database queries to be executed in parallel.
      
      With some crude testing using the Apache HTTP server benchmarking tool (ab
      from the httpd package), the max request latency does seem to drop when
      multiple threads are used, especially when the database queries are slow (I
      tested by adding usleep to the worker thread code).
      
      * src/cuirass/database.scm (with-database): Pass #:parallelism to
      make-worker-thread-channel.
      b9031db9
    • Christopher Baines's avatar
      Enable make-worker-thread-channel to create multiple worker threads. · faf4bfdf
      Christopher Baines authored
      This will allow running multiple threads, that all listen on the same channel,
      enabling processing multiple jobs at one time.
      
      * src/cuirass/utils.scm (make-worker-thread-channel): Add a #:parallelism
      argument, and create as many threads as the given parallelism.
      faf4bfdf
    • Christopher Baines's avatar
      Adjust make-worker-thread-channel to take an initializer. · e34d773f
      Christopher Baines authored
      While this is a generic method, and initializer function will give the
      flexibility required to create multiple worker threads for performing SQLite
      queries, each with it's own database connection (as a result of calling the
      initializer once for each thread). Without this change, they'd all have to use
      the same connection, which would not work.
      
      * src/cuirass/utils.scm (make-worker-thread-channel): Change procedure to take
      an initializer, rather than arguments directly.
      * src/cuirass/database.scm (with-database): Adjust to call
      make-worker-thread-channel with an initializer.
      * tests/database.scm (db-init): Change to use make-worker-thread-channel
      initializer.
      * tests/http.scm (db-init): Change to use make-worker-thread-channel
      initializer.
      e34d773f
    • Christopher Baines's avatar
      utils: Change critical section terminology to worker threads. · 0d23a6d3
      Christopher Baines authored
      As far as I'm aware, it's necessary to use a separate thread for interacting
      with SQLite as one of the threads used for fibers will be blocked while the
      SQLite query is running.
      
      This doesn't mean all queries have to be executed one at a time though,
      providing the queries are executed outside the threads used by fibers, and a
      single connection isn't used in multiple threads.
      
      These changes start to move in this direction, first by just changing the
      terminology.
      
      * src/cuirass/base.scm (clear-build-queue, cancel-old-builds): Change
      with-db-critical-section to with-db-worker-thread.
      * src/cuirass/database.scm (with-db-critical-section): Rename syntax rule to
      with-db-worker-thread.
      (db-add-input, db-add-checkout, db-add-specification, db-remove-specification,
      db-get-inputs, db-get-specification, db-add-evaluation,
      db-set-evaluations-done, db-set-evaluation-done, db-add-derivation-output,
      db-add-build, db-update-build-status!, db-get-output, db-get-outputs,
      db-get-builds-by-search, db-get-builds, db-get-build derivation-or-id,
      db-add-event, db-get-events, db-delete-events-with-ids-<=-to,
      db-get-pending-derivations, db-get-checkouts, db-get-evaluations,
      db-get-evaluations-build-summary, db-get-evaluations-id-max,
      db-get-evaluation-summary, db-get-builds-query-min, db-get-builds-query-max,
      db-get-builds-min, db-get-builds-max, db-get-evaluation-specification): Change
      from using with-db-critical-section to
      with-db-worker-thread.
      (with-database): Change syntax rule to use make-worker-thread-channel,
      renaming from make-critical-section.
      * src/cuirass/utils.scm (%critical-section-args): Rename parameter to
      %worker-thread-args.
      (make-critical-section): Rename to make-worker-thread-channel, and adjust
      parameter and docstring.
      (call-with-critical-section): Rename to call-with-worker-thread and adjust
      parameter.
      (with-critical-section): Rename to with-worker-thread, and adjust to call
      call-with-worker-thread.
      * tests/database.scm (db-init): Use make-worker-thread-channel rather than
      make-critical-section.
      * tests/http.scm (db-init): Use make-worker-thread-channel rather than
      make-critical-section.
      0d23a6d3
    • Christopher Baines's avatar
      Alter the Builds table to have an id field · fa412cdb
      Christopher Baines authored
      The internal rowid's are used for builds as you can request builds by using
      the rowid in the URL.
      
      The motivation here is to enable running VACUUM operations in SQLite, without
      risking the rowid's for Builds changing. It would be bad if they change, as
      they're used in the URL's for builds.
      
      * src/schema.sql (Builds): Add id column.
      * src/curiass/dataabse.scm (db-add-build): Change PRIMARYKEY constraint to
      UNIQUE constraint.
      * src/sql/upgrade-6.sql: New file.
      * Makefile.am (dist_sql_DATA): Add it.
      fa412cdb
  8. Jan 25, 2020
  9. Jan 18, 2020
  10. Jan 16, 2020
    • Christopher Baines's avatar
      Support returning build information by output. · 46f73b6b
      Christopher Baines authored
      Being able to take a derivation and query the build information is useful, but
      in cases where there are multiple derivations that produce the same outputs,
      the probability of getting the data back from Cuirass is reduced.
      
      This is because Cuirass might not have build the exact derivation you have,
      but a different derivation that produces the same outputs (this can commonly
      happen when a related fixed output derivation changes).
      
      Cuirass doesn't store derivations if they produce the same outputs as a
      derivation it already knows about, so it can't determine if this is the
      case. Therefore, provide a way of querying build results by output, rather
      than derivation.
      
      The motivation behind this is to make it easier to import build information in
      to the Guix Data Service.
      
      * src/cuirass/database.scm (db-get-output): New procedure.
      * src/cuirass/http.scm (respond-output-not-found): New procedure.
      (request-path-components): Handle /output/… requests.
      * doc/cuirass.texi (Build information): Mention that you can get build
      information by output.
      46f73b6b
    • Christopher Baines's avatar
      Support publishing evaluation events · 267649c9
      Christopher Baines authored
      * src/cuirass/database.scm (db-add-evaluation): Record the creation of new
      evaluations as events.
      (db-set-evaluation-done): Record when evaluations finish as an event.
      * src/cuirass/http.scm (url-handler): Add a new /api/evaluation-events page.
      267649c9
    • Christopher Baines's avatar
      Support publishing build events · 12def48b
      Christopher Baines authored
      Add a table to store events, which have a type and a JSON blob. These can be
      used to record changes, this commit inserts events when new builds are
      created, and when the status of builds change.
      
      The EventsOutbox table is then used to track when events have been sent
      out. This is done through the new cuirass-send-events script.
      
      * Makefile.am (bin_SCRIPTS): Add bin/cuirass-send-events.
      .gitignore: Add bin/cuirass-send-events.
      (dist_pkgmodule_DATA): Add src/cuirass/send-events.scm.
      (dist_sql_DATA): Add src/sql/upgrade-5.sql.
      (EXTRA_DIST): bin/cuirass-send-events.in.
      (bin/cuirass-send-events): New rule.
      * bin/cuirass-send-events.in: New file.
      * src/cuirass/send-events.scm: New file.
      * src/sql/upgrade-5.sql: New file.
      * src/cuirass/database.scm (changes-count): New procedure.
      (db-update-build-status!): Call db-add-event after updating the build status.
      (db-add-event): New procedure.
      (db-add-build): Insert an event when a new build is inserted.
      (db-delete-events-with-ids-<=-to): New procedure.
      * src/schema.sql (Events): New table.
      12def48b
  11. Nov 03, 2019
  12. Oct 30, 2019
  13. Oct 23, 2019
Loading