Skip to content
Snippets Groups Projects
  1. Apr 05, 2020
  2. Apr 01, 2020
  3. Mar 25, 2020
  4. Mar 24, 2020
  5. Mar 21, 2020
  6. Mar 18, 2020
  7. Mar 12, 2020
    • Romain Geissler's avatar
      Make sure IsATTY does not clobber errno. · a1b0173d
      Romain Geissler authored
      Exposition of the problem:
      > cat main.cpp
      
      TEST(errnoTest, errnoTest)
      {
          ASSERT_EQ(errno, 0);
      }
      
      int main(int argc, char** argv)
      {
          ::testing::InitGoogleTest(&argc, argv);
      
          return RUN_ALL_TESTS();
      }
      
      Compiled with gcc 10 like this:
      > g++ -pthread -o runtest main.cpp -Wl,-Bstatic -lgtest -Wl,-Bdynamic
      
      Before patch:
      >  ./runtest
      [==========] Running 1 test from 1 test suite.
      [----------] Global test environment set-up.
      [----------] 1 test from errnoTest
      [ RUN      ] errnoTest.errnoTest
      [       OK ] errnoTest.errnoTest (0 ms)
      [----------] 1 test from errnoTest (0 ms total)
      
      [----------] Global test environment tear-down
      [==========] 1 test from 1 test suite ran. (0 ms total)
      [  PASSED  ] 1 test.
      
      (output is colored, I run this inside an interactive terminal).
      
      > ./runtest | cat
      [==========] Running 1 test from 1 test suite.
      [----------] Global test environment set-up.
      [----------] 1 test from errnoTest
      [ RUN      ] errnoTest.errnoTest
      main.cpp:5: Failure
      Expected equality of these values:
        (*__errno_location ())
          Which is: 25
        0
      [  FAILED  ] errnoTest.errnoTest (0 ms)
      [----------] 1 test from errnoTest (0 ms total)
      
      [----------] Global test environment tear-down
      [==========] 1 test from 1 test suite ran. (0 ms total)
      [  PASSED  ] 0 tests.
      [  FAILED  ] 1 test, listed below:
      [  FAILED  ] errnoTest.errnoTest
      
       1 FAILED TEST
      
      (output is not colored, since IsTTY return false, because of the pipe,
      however it also clobbered errno for the tests).
      
      After the patch, both cases are working fine:
      > ./runtest
      [==========] Running 1 test from 1 test suite.
      [----------] Global test environment set-up.
      [----------] 1 test from errnoTest
      [ RUN      ] errnoTest.errnoTest
      [       OK ] errnoTest.errnoTest (0 ms)
      [----------] 1 test from errnoTest (0 ms total)
      
      [----------] Global test environment tear-down
      [==========] 1 test from 1 test suite ran. (0 ms total)
      [  PASSED  ] 1 test.
      
      > ./runtest | cat
      [==========] Running 1 test from 1 test suite.
      [----------] Global test environment set-up.
      [----------] 1 test from errnoTest
      [ RUN      ] errnoTest.errnoTest
      [       OK ] errnoTest.errnoTest (0 ms)
      [----------] 1 test from errnoTest (0 ms total)
      
      [----------] Global test environment tear-down
      [==========] 1 test from 1 test suite ran. (0 ms total)
      [  PASSED  ] 1 test.
      a1b0173d
  8. Feb 29, 2020
    • Abseil Team's avatar
      Googletest export · e588eb1f
      Abseil Team authored
      Rename internal color enumerators to avoid conflicts with curses.h macro definitions.
      Fixes #2685
      
      PiperOrigin-RevId: 297639382
      e588eb1f
    • Abseil Team's avatar
      Googletest export · 909b1ccf
      Abseil Team authored
      Relax the implementation of MatcherCast to allow conversion of `Matcher<T>` to
      `Matcher<const T&>`. They have the same match signature.
      
      PiperOrigin-RevId: 297115843
      909b1ccf
    • Abseil Team's avatar
      Googletest export · fd538161
      Abseil Team authored
      Allow construction of an Action from a callable of zero args
      
      Action already allows construction from a callable with the same args as the mocked function, without needing to wrap the callable in Invoke. However, if you don't care about the arguments to the mocked function you need to either accept all of them or wrap your callable in InvokeWithoutArgs. This change makes both of those unnecessary, since it allows you to pass a no-args callable to Action directly.
      
      PiperOrigin-RevId: 296117034
      fd538161
  9. Feb 21, 2020
  10. Feb 14, 2020
    • Abseil Team's avatar
      Googletest export · 23b2a3b1
      Abseil Team authored
      Remove the CMAKE_CXX_STANDARD from GoogleTest's CMakeLists.txt
      
      This causes ABI issues since it can create a mixed-mode build.  The
      value should be inherited from the top-level build if it needs to be
      set.
      
      PiperOrigin-RevId: 294730724
      23b2a3b1
  11. Feb 12, 2020
    • Abseil Team's avatar
      Googletest export · 6f5fd0d7
      Abseil Team authored
      Add gmock Matcher<std::string_view> specialization.
      
      PiperOrigin-RevId: 294443240
      6f5fd0d7
    • Abseil Team's avatar
      Googletest export · d0930731
      Abseil Team authored
      Fix gmock_gen to use MOCK_METHOD instead of old style macros.  Fix several
      related bugs in argument parsing and return types.
      - handle commas more correctly in return types
      - handle commas correctly in arguments
      - handle default values more correctly
      
      PiperOrigin-RevId: 294435093
      d0930731
    • Abseil Team's avatar
      Googletest export · 56de7cc8
      Abseil Team authored
      Fix gmock_gen to use MOCK_METHOD instead of old style macros.
      
      PiperOrigin-RevId: 294360947
      56de7cc8
    • Abseil Team's avatar
      Googletest export · 360f5f70
      Abseil Team authored
      Fix gmock_gen to use MOCK_METHOD instead of old style macros.
      
      PiperOrigin-RevId: 294332975
      360f5f70
    • Abseil Team's avatar
      Googletest export · 139fa202
      Abseil Team authored
      Refactor function GetNextPrime so that the loop precondition is checked before
      loop instead of during every loop run.  Also by removing the loop condition,
      it shows that the only exit from the loop is the return statement.
      
      PiperOrigin-RevId: 293932783
      139fa202
  12. Feb 08, 2020
    • Abseil Team's avatar
      Googletest export · 41b5f149
      Abseil Team authored
      Get rid of gmock-generated-matchers.h and gmock-generated-matchers.h.pump.
      
      Stop using pump for MATCHER* macroses generation.
      
      PiperOrigin-RevId: 293878808
      41b5f149
    • durandal's avatar
      Googletest export · 2d6d7a01
      durandal authored
      Tag the function generated by MATCHER with GTEST_ATTRIBUTE_UNUSED_ to fix CI builds of gmock-matchers_test.cc vs. -Wunused-function.
      
      See https://github.com/google/googletest/pull/2697 for breakage.
      
      PiperOrigin-RevId: 293669752
      2d6d7a01
    • Abseil Team's avatar
      Googletest export · fbf67a70
      Abseil Team authored
      Get rid of gmock-generated-function-mockers.h and
      gmock-generated-function-mockers.h.pump.
      
      Stop using pump for GMOCK_METHOD* macroses generation.
      
      PiperOrigin-RevId: 293454519
      fbf67a70
    • Abseil Team's avatar
      Googletest export · 11d9834e
      Abseil Team authored
      ...text exposed to GitHub repo https://www.github.com/google/googletest
      
      PiperOrigin-RevId: 293438092
      11d9834e
    • Abseil Team's avatar
      Googletest export · d02e2772
      Abseil Team authored
      Pass method's parameters count to internal GMOCK_METHOD* macro.
      
      This will help removing copypaste in every GMOCK_METHOD* macro in future.
      
      PiperOrigin-RevId: 292932554
      d02e2772
    • Abseil Team's avatar
      Googletest export · 4f660912
      Abseil Team authored
      Fix std::move to std::forward where appropriate to support reference types.
      
      PiperOrigin-RevId: 292923058
      4f660912
Loading