Skip to content
Snippets Groups Projects
  1. Dec 06, 2019
  2. Dec 03, 2019
  3. Nov 28, 2019
  4. Nov 27, 2019
  5. Nov 26, 2019
  6. Nov 25, 2019
  7. Nov 23, 2019
  8. Nov 21, 2019
  9. Nov 20, 2019
    • Abseil Team's avatar
      Googletest export · 50cfbb72
      Abseil Team authored
      Update stale comments to point to proper location.
      
      PiperOrigin-RevId: 281157036
      50cfbb72
  10. Nov 17, 2019
    • xyb's avatar
      Fix internal memory leak in Windows _Crt report. · dcdb6506
      xyb authored
      We use "MemoryIsNotDeallocated" to aovid internal expected leak reported
      in Windows _Crt report, like:
      
          {
          #ifdef _MSC_VER
          	MemoryIsNotDeallocated memory_is_not_deeallocated;
          #endif
      
          	static ThreadIdToThreadLocals* map = new
      	ThreadIdToThreadLocals();
      	return map;
          }
      
      But int the above code, only "new ThreadIdToThreadLocals()" is
      protected, if we invoke "insert()" function of the return value,
      the memory allocated in "insert()" will be reported to _Crt report
      also. This change try to fix this issue.
      dcdb6506
  11. Nov 16, 2019
    • Brian Gianforcaro's avatar
      Fix FlatTuple compilation on older msvc. · 0c469a5a
      Brian Gianforcaro authored
      googletest 1.10.0 fails to compile on msvc version 19.00.23917
      with one compilation error:
      
      src\googletest\include\gtest\internal\gtest-internal.h(1188) : error C2039:
      'FlatTupleBase<testing::internal::FlatTuple<bool,bool>,testing::internal::IndexSequence<0,1> >':
      is not a member of 'testing::internal::FlatTuple<bool,bool>'
      
      This PR fixes the compilation error by explicitly specifying the full type that Indices is
      located in the base type.
      0c469a5a
    • Andy Getz's avatar
      Merge pull request #2521 from Sinclair-John:master · c27acebb
      Andy Getz authored
      PiperOrigin-RevId: 280666222
      c27acebb
  12. Nov 14, 2019
  13. Nov 09, 2019
    • Abseil Team's avatar
      Googletest export · d5707695
      Abseil Team authored
      Correctly deal with stringification, and forbid empty arguments where they could slip thought, in the type parameterized test API.
      
      Note: even where empty args work, it's likely to result in technically invalid code by virtue of creating reserved identifiers:
      https://en.cppreference.com/w/cpp/language/identifiers
      PiperOrigin-RevId: 279330971
      d5707695
    • Abseil Team's avatar
      Googletest export · 681454da
      Abseil Team authored
      Clone+exec death test allocates a single page of stack to run chdir + exec on.
      This is not enough when gtest is built with ASan and run on particular
      hardware.
      
      With ASan on x86_64, ExecDeathTestChildMain has frame size of 1728 bytes.
      
      Call to chdir() in ExecDeathTestChildMain ends up in
      _dl_runtime_resolve_xsavec, which attempts to save register state on the stack;
      according to cpuid(0xd) XSAVE register save area size is 2568 on my machine.
      
      This results in something like this in all death tests:
        Result: died but not with expected error.
        ...
        [  DEATH   ] AddressSanitizer:DEADLYSIGNAL
        [  DEATH   ] =================================================================
        [  DEATH   ] ==178637==ERROR: AddressSanitizer: stack-overflow on address ...
      
      PiperOrigin-RevId: 278709790
      681454da
  14. Nov 06, 2019
Loading